Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Known fields] Add fields to the know fields for the index pattern of alerts #3924

Merged
merged 2 commits into from
Mar 31, 2022
Merged

[Known fields] Add fields to the know fields for the index pattern of alerts #3924

merged 2 commits into from
Mar 31, 2022

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Mar 29, 2022 •
edited
Loading

Description

This PR adds some fields to the known fields for the index pattern of alerts. These fields are used as the default fields when creating the index pattern of alerts and there are no related indices.

We extract the fields used in the visualizations and check if they were defined in the know fields file.

Related to #3918

Test

  • With an environment without indices related to Wazuh alerts, access to the Wazuh plugin for Kibana. The health check should run and create the index pattern for the Wazuh alerts with the fields used in the visualizations of all current modules. Access to each module in the two modes (with and without the selected agent) and should appear the toast that says `The index pattern was refreshed successfully.

@Desvelao Desvelao added the type/enhancement Enhancement issue label Mar 29, 2022
@Desvelao Desvelao changed the title [] Add fields to the know fields for the index pattern of alerts [Known fields] Add fields to the know fields for the index pattern of alerts Mar 29, 2022
@Desvelao Desvelao force-pushed the fix/toast-refresh-index-pattern-3918 branch from 20a009f to bceb7b6 Compare March 30, 2022 07:12
@Desvelao Desvelao linked an issue Mar 30, 2022 that may be closed by this pull request
[Modules][Dashboard] The toast to reload the page due to the index pattern fields were refreshed appear constatly despite to refresh the page previously. #3918
Closed
@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 4.04% ( 1476 / 36547 )
Branches 1.61% ( 459 / 28479 )
Functions 2.98% ( 266 / 8934 )
Lines 4.09% ( 1428 / 34939 )

asteriscos
asteriscos approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

@Desvelao Desvelao merged commit 0a44d4d into 4.3-7.10 Mar 31, 2022
@Desvelao Desvelao deleted the fix/toast-refresh-index-pattern-3918 branch March 31, 2022 06:17
@asteriscos asteriscos linked an issue Apr 4, 2022 that may be closed by this pull request
Index pattern message popping up everytime the app is refreshed #3939
Closed
@AlexRuiz7 AlexRuiz7 mentioned this pull request May 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteriscos asteriscos asteriscos approved these changes

Assignees

@asteriscos asteriscos

@Desvelao Desvelao

Labels
type/enhancement Enhancement issue
Projects
None yet
Milestone
No milestone
2 participants
@Desvelao @asteriscos