The icon correct groups files #4114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desvelao
reviewed
Apr 29, 2022
| color="primary" | ||
| /> | ||
| </EuiToolTip> | ||
| { | ||
| item.filename === 'agent.conf' && | ||
| <WzButtonPermissions |
There was a problem hiding this comment.
thought: I was researching and the button appears in a cell of a table with the group's files. The required permission to read the file is:
- action:
group:read - resource:
group:id:<group_id>
I didn't see more specific permission to read this file, so we could use a button component that doesn't check the user's permissions. If for any reason, the user's permissions changed and the table was rerender by some reason, the WzButtonPermission could avoid to the user that click on and cause a request error getting the content.
Desvelao
reviewed
Apr 29, 2022
Comment on lines
14
to
56
| this.showFile = async(item) => { | ||
| let result = await this.groupsHandler.getFileContent( | ||
| `/groups/${itemDetail.name}/files/${item.filename}/xml` | ||
| ); | ||
|
|
||
| if (Object.keys(result).length == 0) { | ||
| result = ''; | ||
| } | ||
|
|
||
| const data = typeof result === 'object' | ||
| ? JSON.stringify(result, null, 2) | ||
| : result.toString() | ||
|
|
||
| const file = { | ||
| name: item.filename, | ||
| content: data, | ||
| isEditable: false, | ||
| groupName: itemDetail.name | ||
| }; | ||
|
|
||
| this.tableProps.updateFileContent(file); | ||
| } | ||
|
|
||
| this.editFile = async (item) => { | ||
|
|
||
| let result = await this.groupsHandler.getFileContent( | ||
| `/groups/${itemDetail.name}/files/${item.filename}/xml` | ||
| ); | ||
| if (Object.keys(result).length == 0) { | ||
| result = ''; | ||
| } | ||
|
|
||
| const data = this.autoFormat(result); | ||
|
|
||
| const file = { | ||
| name: 'agent.conf', | ||
| content: data, | ||
| isEditable: true, | ||
| groupName: itemDetail.name, | ||
| }; | ||
|
|
||
| this.tableProps.updateFileContent(file); | ||
| } |
There was a problem hiding this comment.
nitpick: These 2 methods seem to be similar, maybe we could refactor them to share the logic.
matiasmoreno876
approved these changes
Apr 29, 2022
Desvelao
approved these changes
Apr 29, 2022
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In the groups file table, there was a file (agent.conf) that showed you the only read icon and sent you to the view to edit the file, so I separated the show and edit function and added the edit button
Issue:
Test:
agent.conffileScreenshot: