Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lzhuf binary should not be packaged in python egg #244

Open
wb8tyw opened this issue Jul 24, 2022 · 2 comments
Open

lzhuf binary should not be packaged in python egg #244

wb8tyw opened this issue Jul 24, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@wb8tyw
Copy link
Owner

wb8tyw commented Jul 24, 2022

Current python egg building script for d-rats is building and installing a script with a lzhuf binary.
This makes the resulting egg only installable on that specific platform.

The proper procedure is for a pip install of the resulting egg to do a local build of the lzhuf binary, which means that the end user getting the egg must already have to pre-installed the tools to build it.

In the future, we should look into getting the lzhuf utility pre-built in a distro specific package that can be pre-installed before installing d-rats.

@wb8tyw wb8tyw added the bug Something isn't working label Jul 24, 2022
@wb8tyw
Copy link
Owner Author

wb8tyw commented Jul 24, 2022

If we change this, we make it harder to install d-rats.

@wb8tyw
Copy link
Owner Author

wb8tyw commented Jul 31, 2022

I think instead of working on how to remove the lzhuf from pip installable packages, the time is better spent in working out how to create what is known as First Class Packages. These are packages like RPMs, DEBs, etcetera.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant