-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows 10 OS: Tests Fail #41
Comments
None of the files that were attempted to be rperl compiled, should have ever been rperl compiled. There is a black/whitelist in rperl of modules file paths to exclude, the blacklist in rperl is broken on Windows since July 2015. The black/whitelist is in https://github.com/wbraswell/rperl/blob/master/lib/RPerl/CompileUnit/Module/Class.pm#L115 |
@bulk88 That makes sense. I haven't looked at it yet, but is this a file name canonicalization issue? |
@nanis |
@wbraswell These are problems that happen when I type |
@nanis |
If I can find time to figure it out, I'll let you know. BTW, trace output says |
Devel::* should be skipped due to this: Since you say it is not properly being skipped, then obviously that is likely part of the problems of running RPerl in Windows, and needs to somehow be debugged. |
Using MSVC with RPerl fails badly because RPerl uses extensively C++11 features which MSVC doesnt support, yet, if ever. Stick to GCC perl (strawberry). |
@bulk88 I am not sure I understand ... Wouldn't there have been a compile error then? |
@nanis https://github.com/wbraswell/rperl/blob/master/INSTALL#L83-L92 |
I wasn't interested in RPerl at all until you commented on my blog post on Facebook. I took that as an invitation to try RPerl, checked out the repo, and did I don't really read At this point, I am happy with the 33% improvement in Perl's arithmetic performance, so I am not going to spend more time on this. If I need C++ performance, I'll write C++. Thank you. |
This is on Windows 10,
perl
5.23.5 built with VS2013. Here are some examples of failures:The relevant code in Devel::StackTrace:
RPerl::CompileUnit::Module::Class seems to want to handle something like this, but wants the word "hide" to occur on the same line as the
package
statement.Now, if I go and "fix" the line in
Devel::StackTrace
by makingpackage DB;
a single line statement, here is what I get:t\13_compile_sort.t .. Improperly formed package declaration found in file 'c:/opt/perl/site/5.23.5/lib/Exception/Class/Base.pm' near ' package => 'package',', croaking at t\13_compile_sort.t line 0.
Here is the relevant part of Exception::Class::Base:
In this case, this might be a bug in
Exception::Class::Base
because the reserved wordpackage
should be quoted when used as a hash key, so I may open an issue with the author of that module.It may also make sense to ask the
Devel::StackTrace
author to use the word "hide" in that package statement.However, after fixing both of these, I get:
t\13_compile_sort.t .. Use of uninitialized value $module_file_line in pattern match (m//) at D:\Src\rperl\blib\lib/RPerl/CompileUnit/Module/Class.pm line 157, <$MODULE_FILE> line 402. End of file 'c:/opt/perl/5.23.5/lib/File/Basename.pm' reached without finding '=cut' end of multi-line POD comment '=head1', croaking at t\13_compile_sort.t line 0.
which I have not tried to diagnose at this point.
Here are the problematic tests:
The text was updated successfully, but these errors were encountered: