Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t/09_interpret_execute.t empties its candidate file list on win32 and therefore fails #56

Closed
bulk88 opened this issue Jul 13, 2016 · 2 comments
Assignees

Comments

@bulk88
Copy link
Collaborator

bulk88 commented Jul 13, 2016

Test fails with Win32 GCC perl

C:\sources\rperl>perl -Ilib t/09_interpret_execute.t
You said to run 0 tests at t/09_interpret_execute.t line 120.

C:\sources\rperl>

tracing the code shows https://github.com/wbraswell/rperl/blob/master/lib/RPerl/Compiler.pm#L864 always returns $input_path unmodified (IE the file paths passed are relative and need no triming). If sub post_processor__absolute_path_delete returns $input_path unmodified, the path is deleted from candidates to run list ( AKA %{$test_file}) at https://github.com/wbraswell/rperl/blob/master/t/09_interpret_execute.t#L109 . Actually since every path in %{$test_file} seems to be relative on my Win32 machine, the %{$test_file} hash is emptied of all file paths. Therefore t/09_interpret_execute.t fails with "You said to run 0 tests at t/09_interpret_execute.t line 120."

There is no explanation in 0e4d32a why if the path isn't trimmed, it is deleted from the candidate list.

@bulk88
Copy link
Collaborator Author

bulk88 commented Jul 13, 2016

If I remove the delete line at https://github.com/wbraswell/rperl/blob/master/t/09_interpret_execute.t#L111 I get

C:\sources\rperl>prove -Ilib t/09_interpret_execute.t
t/09_interpret_execute.t .. ok
All tests successful.
Files=1, Tests=162, 244 wallclock secs ( 0.11 usr +  0.05 sys =  0.16 CPU)
Result: PASS

C:\sources\rperl>

but IDK if that is the right solution.

@wbraswell wbraswell self-assigned this Jul 14, 2016
@bulk88
Copy link
Collaborator Author

bulk88 commented Jul 14, 2016

fixed by 7bf4c33

@bulk88 bulk88 closed this as completed Jul 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants