Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of ENSIP-15 for the funky emoji domains #39

Open
palevoo opened this issue Mar 9, 2024 · 1 comment
Open

Support of ENSIP-15 for the funky emoji domains #39

palevoo opened this issue Mar 9, 2024 · 1 comment

Comments

@palevoo
Copy link

palevoo commented Mar 9, 2024

Hey @wealdtech thank you for maintaining this!

I've run into issue with the following domain:

https://app.ens.domains/trish🫧.eth

Normalise -> ToUnicode throws the following error: failed to convert to standard unicode: idna: disallowed rune U+1FAE7

From what I've found so far it seems these emojis are part of the normalization standard proposal, which is still in draft:

https://docs.ens.domains/ensip/15

There seems to be some support already https://www.npmjs.com/package/@adraffy/ens-normalize

Was wondering if there are plans or resources to implement it while it is still in draft?

Thanks!

@mcdee
Copy link
Collaborator

mcdee commented Mar 9, 2024

This seems to work fine for me:

package main

import (
        "fmt"

        ens "github.com/wealdtech/go-ens/v3"
)

func main() {
        res, err := ens.NameHash("trish🫧.eth")
        if err != nil {
                panic(err)
        }
        fmt.Printf("%#x\n", res)
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants