Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double Success message on ci send #111

Closed
gaelph opened this issue Sep 20, 2021 · 1 comment
Closed

Double Success message on ci send #111

gaelph opened this issue Sep 20, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@gaelph
Copy link
Contributor

gaelph commented Sep 20, 2021

When sending env to a ci service, the success message is displayed twice :

❯ ks ci send --env prod
Environment dev up to date ✔
Environment staging up to date ✔
Environment prod up to date ✔
You are about to send the 'prod' environment to your CI services.
? Continue? [y/N] y█

 OK  Secrets successfully sent to CI service, environment prod. See https://github.com/wearede
vx/keystone-action to use them.


 OK  Secrets successfully sent to CI service, environment prod. See https://github.com/wearede
vx/keystone-action to use them.
@gaelph gaelph added the bug Something isn't working label Sep 20, 2021
@gaelph
Copy link
Contributor Author

gaelph commented Oct 25, 2021

Turns out, it is not actually a bug, but this is in dire need of improvements : each "OK" line is for a different CI Service, so the CI service name should (must !) appear in the message !
Eg. : OK Secrets successfully sent to "github-ci" CI servic, environment "prod". …

@gaelph gaelph closed this as completed in 217737f Oct 26, 2021
gaelph pushed a commit that referenced this issue Oct 26, 2021
refactor(archive): move more code into the archive package
e63866e 
Squashed commit of the following:

commit a30f39e
Author: Gaël Philippe <gaelphilippe@Gaels-MacBook-Pro.local>
Date:   Tue Oct 26 13:57:15 2021 +0200

    doc(archive): document the ExtractWithPassphrase function

commit af3d0c7
Author: Gaël Philippe <gaelphilippe@Gaels-MacBook-Pro.local>
Date:   Tue Oct 26 12:16:25 2021 +0200

    refactor the backup/restore into the archive package

commit ec4ac4a
Author: Gaël Philippe <gaelphilippe@Gaels-MacBook-Pro.local>
Date:   Tue Oct 26 10:59:23 2021 +0200

    refactor(backup)

commit 217737f
Author: Gaël Philippe <gaelphilippe@Gaels-MacBook-Pro.local>
Date:   Tue Oct 26 10:27:04 2021 +0200

    fix(ci send): successe message shows CI service name

    Closes #111
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gaelph