-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ofsted Plugin #59
Comments
an ofsted api key will not be a requirement to run this. there is a chunk of this app which shows services from ofsted, but it treats it as just another rails model/database table. we have a separate application which will handle authenticating with and retrieving data from ofsted's old soap api, transforming the response into a modern rest api, and then this repository has several rake tasks which will query that api. we will probably set up some basic authentication between the two when the time comes to make a live connection - hopefully in january. |
we've added oauth provider functionality to this app since you posted that, and we're now following the model of other apps hooking into its identity features. an example: https://github.com/wearefuturegov/tell-us-who-you-employ |
thought about this some more - i think a reasonable enhancement would be to activate ofsted-related ui (the nav link, controller and user permission) based on some environment config. |
Firstly, this is looking great and really exciting. I was wondering whether an Ofsted API key is a requirement or whether it can be omitted. Given that the process to get an Ofsted key is a pretty weighty one. I wanted to suggest a proposal to extract the Ofsted functionality into a plugin.
Could you clarify if the Ofsted key is a requirement? And whether a plugin is a interesting / useful concept?
The text was updated successfully, but these errors were encountered: