Add tsc to check TypeScript files
#575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocean90
requested changes
Jan 13, 2023
There was a problem hiding this comment.
Thanks for working on this! Looks like the tests are currently failing on Windows. Can you try using EOL as in
lint-action/test/linters/params/flake8.js
Line 13 in 2044565
ocean90
requested changes
Jan 13, 2023
There was a problem hiding this comment.
Can you please add tsc to https://github.com/wearerequired/lint-action#supported-tools and https://github.com/wearerequired/lint-action#linter-support?
|
Sure, sorry forgot that! :-) |
ocean90
approved these changes
Jan 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented a linter for the TypeScript compiler
tsc --noEmitcommand. This command checks for TypeScript errors without compiling the actual project.