Unicode error fixes #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abadger
force-pushed
the
unicode-error-fixes
branch
from
cf2d760
to
8764f65
Compare
abadger
force-pushed
the
unicode-error-fixes
branch
from
7e8b0f5
to
0ce8bc5
Compare
* Port some logging tests to pytest parametrized functions * Add nonascii tests to the parametrized tests. This exposes a few places where we fail to do the right thig with nonascii values
abadger
force-pushed
the
unicode-error-fixes
branch
from
0ce8bc5
to
9e6c53d
Compare
Messages on Py3 that are bytes need to be turned into text strings so that braces-style formatting will work.
abadger
force-pushed
the
unicode-error-fixes
branch
from
25a718f
to
da7fec0
Compare
|
Is this ready to merge? Also, just wanted to make sure we covered both str & bytes for the message text (first arg to |
|
Not ready yet. Test failure I think I need to pin the version of pytest
(newer pytest deps aren't python 3.3 or python 2.6 compatible) and this is
only fixing one thing. I think most of the issues are in the Messages
class but there is likely to be some errors in the Outputs once Messages is
fixed and istr lib/converter.py having issues too.
I've been trying to update unittest code to use pytest.mark.parametrize and
add in non-ascii values as I go along as well.
|
… on those platforms
abadger
force-pushed
the
unicode-error-fixes
branch
from
a108098
to
61efc00
Compare
|
Okay, this is now mergable if we want. It isn't a fix for all of our unicode problems but it fixes one case. It also adds the helper utilities (to_text, to_bytes, and to_native) that we'll want as we fix the rest of the code base. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch will eventually have unicode error fixes. For starters, I'm updating unittests to get them ready to have non-ascii values which will fail so that we know if the fixes are doing what htey're supposed to.