New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode error fixes #83

Merged
merged 3 commits into from Dec 8, 2017

Conversation

Projects
None yet
2 participants
@abadger
Collaborator

abadger commented Nov 18, 2017

This branch will eventually have unicode error fixes. For starters, I'm updating unittests to get them ready to have non-ascii values which will fail so that we know if the fixes are doing what htey're supposed to.

abadger added some commits Nov 28, 2017

Refactor some logging tests
* Port some logging tests to pytest parametrized functions
* Add nonascii tests to the parametrized tests.  This exposes a few
  places where we fail to do the right thig with nonascii values
Fix unicode errors when messages are formatted on Py3
Messages on Py3 that are bytes need to be turned into text strings so
that braces-style formatting will work.
@wearpants

This comment has been minimized.

Owner

wearpants commented Nov 30, 2017

Is this ready to merge?

Also, just wanted to make sure we covered both str & bytes for the message text (first arg to debug(..)) - saw that for fields & names, wasn't sure if it was covered elsewhere...

@abadger

This comment has been minimized.

Collaborator

abadger commented Nov 30, 2017

@abadger

This comment has been minimized.

Collaborator

abadger commented Dec 4, 2017

Okay, this is now mergable if we want. It isn't a fix for all of our unicode problems but it fixes one case. It also adds the helper utilities (to_text, to_bytes, and to_native) that we'll want as we fix the rest of the code base.

@wearpants wearpants merged commit fbbdee4 into wearpants:master Dec 8, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment