route-matches Doesn't Match from Servlet Root

[wtetzner]

(defmethod route-matches [::compiled-route Map]
  [route request]
  (route-matches route (if (:absolute? route)
                         (request-url request)
                         (:uri request))))

This method matches on (:uri request), which works fine when using a single servlet that is mapped to /, but with multiple servlets at different urls, it would be better to match from the root of the servlet. Replacing (:uri request) with (.getPathInfo (:servlet-request request)) should be enough:

(defmethod route-matches [::compiled-route Map]
  [route request]
  (route-matches route (if (:absolute? route)
                         (request-url request)
                         (.getPathInfo (:servlet-request request)))))

[weavejester]

:servlet-request is a non-standard key and not guaranteed to exist. Whilst most Ring adapters are based off existing Java web servers, and thus include a :servlet-request key, this is not necessarily the case. I don't want Clout to work with some adapters but crash with others.

A better solution would be to use some middleware that changes the :uri key. For example:

(defn wrap-servlet-path-info [handler]
  (fn [request]
    (if-let [servlet-request (:servlet-request request)]
      (handler (assoc request :uri (.getPathInfo servlet-request)))
      (handler request))))

[wtetzner]

I see. I didn't realize it was intended to work with more than servlet containers. The middleware solution should work fine.