Set ordered names for guest devices #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We will rely on the order specified in the incoming grpc request and the fact that serialization in go shouldn't change the order * We will update flintlock docs to say that if you care about the order of your network interfaces then you must specify them in the order from eth1,eth2,ethX * MMDS device is the first (eth0) > There is no relation between the numbering of the /network-interface > API calls and the number of the network interface in the guest. Rather, > it is usually the order of network interface creation that determines > the number in the guest (but this depends on the distribution). > > For example, when you create two network interfaces by calling > /network-interfaces/1 and then /network-interfaces/0, it may result in > this mapping: > > /network-interfaces/1 -> eth0 > /network-interfaces/0 -> eth1 Source: https://github.com/firecracker-microvm/firecracker/blob/83ec483d4254936e1e2fd4adfe94761611a74a93/FAQ.md#how-does-network-interface-numbering-work Fixes liquidmetal-dev#340
yitsushi
force-pushed
the
340-iface-order
branch
from
dc0dd32
to
ade5e62
Compare
Codecov Report
@@ Coverage Diff @@
## main #344 +/- ##
==========================================
+ Coverage 58.09% 58.20% +0.11%
==========================================
Files 51 51
Lines 2503 2505 +2
==========================================
+ Hits 1454 1458 +4
+ Misses 932 930 -2
Partials 117 117
Continue to review full report at Codecov.
|
Callisto13
previously approved these changes
Jan 6, 2022
Co-authored-by: Claudia <claudiaberesford@gmail.com>
Callisto13
previously approved these changes
Jan 6, 2022
|
actually you'll probably also need to regenerate something after changing those comments |
Callisto13
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
the fact that serialization in go shouldn't change the order
of your network interfaces then you must specify them in the order
from eth1,eth2,ethX
Source: https://github.com/firecracker-microvm/firecracker/blob/83ec483d4254936e1e2fd4adfe94761611a74a93/FAQ.md#how-does-network-interface-numbering-work
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #340
Special notes for your reviewer:
Checklist: