feat: Add list all functionality #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the requirement that a call to GetAllMicroVM must have a namespace argument in the request. We do filtering on the Repo, so it is not harmful to have all params be optional. If a call to GetAllMicroVM is made without namespace or name, then all mvms on the host will be returned. If a call to GetAllMicroVM is made with just name, then all mvms matching that name in any namespace will be returned. If a call to to GetAllMicroVM is made with just namespace, then all mvms under that namespace will be returned. We can consider RBAC implications when we get to that.
richardcase
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the requirement that a call to GetAllMicroVM must have a
namespace argument in the request. We do filtering on the Repo, so it is
not harmful to have all params be optional.
If a call to GetAllMicroVM is made without namespace or name, then all
mvms on the host will be returned.
If a call to GetAllMicroVM is made with just name, then all mvms
matching that name in any namespace will be returned.
If a call to to GetAllMicroVM is made with just namespace, then all mvms
under that namespace will be returned.
We can consider RBAC implications when we get to that.
Checklist: