Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wcloud instance (name) command and loading ~/.wcloudconfig #35

Closed
wants to merge 2 commits into from

Conversation

paulbellamy
Copy link
Contributor

No description provided.

@tomwilkie
Copy link
Contributor

Thanks, Paul!

I don't feel particularly strong about this, but some nits:

  • I preferred instance to context. Whats the rationale behind context?
  • I don't like having the tool modify the config; this doesn't work well for kubectl as it looses all the formatting. I'd prefer the config be static, have the ability to specify a default instance in the config, and pick a config on a per command basis (doing --instance=dev etc)

WDYT?

@paulbellamy
Copy link
Contributor Author

Rationale is that instance is used to mean a different thing in cloud. Potentially, it just needs more thought on how wcloud interacts with different instances, and if you have access to multiple instances, etc...

@tomwilkie
Copy link
Contributor

Rationale is that instance is used to mean a different thing in cloud.

This was my confusion, because as this stands they do not mean different things. But I guess with #41 they will, so context is fine.

@paulbellamy
Copy link
Contributor Author

Closed in favour of #41

@paulbellamy paulbellamy closed this Sep 6, 2016
@tomwilkie tomwilkie deleted the wcloud-instance branch January 16, 2017 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants