This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Purge release on FHR delete #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why does Tiller only mark releases as "deleted" (i.e., what is the purpose of distinguishing between that and purging deletions) |
|
The default behaviour is to prevent a release name to be reuse. I think the main reason would be to track what apps you have discontinued from your cluster. |
|
The main problem with not purging releases is that you would expect from a GitOps Operator to undo any manual changes on a cluster. But if you delete a FHR by mistake, the Helm Operator will error out forever since Tiller will prevent it from applying the state from Git. |
What happens if someone deletes a release manually (without purging)? A different problem, I grant you .. |
squaremo
approved these changes
May 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a FluxHelmResource gets deleted, the corresponding Chart release is only marked as deleted in Tiller. This prevents our users to redeploy the same release at a later time. This PR adds the purge option to the delete operation.