This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
helm-op: Update Kubernetes deps to 1.11 and fix unwanted upgrades #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- generate Helm CRD clientset, informers and listeners for K8s 1.11
- fix unwanted upgrades on K8s 1.11
squaremo
approved these changes
Jul 3, 2018
|
|
||
| [[projects]] | ||
| branch = "master" | ||
| branch = "release-1.11" |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
|
||
| [[projects]] | ||
| branch = "release-1.9" | ||
| branch = "release-1.11" |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| [[override]] | ||
| name = "k8s.io/gengo" | ||
| revision = "b58fc7edb82e0c6ffc9b8aef61813c7261b785d4" | ||
| name = "github.com/json-iterator/go" |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| @@ -343,3 +341,31 @@ func (c *Controller) deleteRelease(fhr ifv1.FluxHelmRelease) { | |||
| } | |||
| return | |||
| } | |||
|
|
|||
| // needsUpdate compares two FluxHelmRelease and determines if any changes occurred | |||
| func needsUpdate(old, new ifv1.FluxHelmRelease) bool { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| @@ -37,7 +37,7 @@ func init() { | |||
| // | |||
| // import ( | |||
| // "k8s.io/client-go/kubernetes" | |||
| // clientsetscheme "k8s.io/client-go/kuberentes/scheme" | |||
| // clientsetscheme "k8s.io/client-go/kubernetes/scheme" | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| @@ -37,7 +37,7 @@ func init() { | |||
| // | |||
| // import ( | |||
| // "k8s.io/client-go/kubernetes" | |||
| // clientsetscheme "k8s.io/client-go/kuberentes/scheme" | |||
| // clientsetscheme "k8s.io/client-go/kubernetes/scheme" | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on K8s 1.11 and 1.10 with
stefanprodan/helm-operator:k8s11-9d5eb919-wip7