This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Use UID of HelmRelease as dry run release name #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents dry run issues when a user has a release name that is 51+ characters long, as our previous strategy was to add '-temp' to the given release name and Helm has a self imposed release name character limit of 53 (51 + '-temp' = >53).
|
If the dry run fails how can you tell from the logs what HelmRelease was it? I assume you'll see just a UID |
|
@stefanprodan see the change to the logger. |
|
That logs the info not the error |
This ensures the given context around the error always points towards the HelmRelease it results from instead of an eventual deverging one. Which for example is the case during dry run operations where the UID from the HelmRelease resource is used.
stefanprodan
approved these changes
Feb 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1703
This prevents dry run issues when a user has a release name that is 51+
characters long, as our previous strategy was to add '-temp' to the
given release name and Helm has a self imposed release name character
limit of 53 (51 + '-temp' = >53).