This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Reorder boot and verify informer cache sync #2103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
helm/informer-sync
branch
2 times, most recently
from
6735611
to
dc07e9b
Compare
hiddeco
changed the title
hiddeco
force-pushed
the
helm/informer-sync
branch
2 times, most recently
from
84b5c99
to
e4b68e0
Compare
|
@squaremo @2opremio added 30 builds to be 100% sure this is a permanent fix, but my previous tests on CircleCI and on my own machine (about 100 cycles all together) did not run into any issues. https://circleci.com/gh/weaveworks/workflows/flux/tree/helm%2Finformer-sync |
|
LGTM, but again, I am not super familiar with the operator. |
2opremio
approved these changes
May 29, 2019
Before this change the operator would hang at random on "waiting for informer caches to sync", without anything else happening or it timing out. After an extensive search in recently merged PRs, this seems to be related to an change of order in #1906, where the informer would be initialized before the operator had registered its event handlers. In addition to reverting this change and ensuring the informer cache is synced before it is used, reorder everything so that the operator is started before anything else that may depend on it, so it can start processing changes from the queue as soon as possible.
hiddeco
force-pushed
the
helm/informer-sync
branch
from
e4b68e0
to
38fa0ec
Compare
squaremo
approved these changes
May 29, 2019
hiddeco
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change the operator would hang at random on "waiting for
informer caches to sync", without anything else happening or it timing
out.
After an extensive search in recently merged PRs, this seems to be
related to an change of order in #1906, where the informer would be
initialized before the operator had registered its event handlers.
In addition to reverting this change and ensuring the informer cache is
synced before it is used, reorder everything so that the operator is
started before anything else that may depend on it, so it can start
processing changes from the queue as soon as possible.
Addresses #2147.