This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Run integration tests in parallel when possible. #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| cmd.Stdout = &out | ||
| cmd.Stderr = &out | ||
|
|
||
| // repace HOSTS in env |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Seems like it would be cleaner to just have one test runner which is always used, and decides whether to talk to the scheduler, vs having run_all.sh and runner, which sometimes one is used vs the other... |
|
Could do; run_all runs a bunch of pretest checks; I take it you're not proposing we write those in go? I could add a run-sequentially flag to running and then always use runner? |
tomwilkie
force-pushed
the
1169-frugal-frugal-frugal
branch
from
7f833b2
to
a53c652
Compare
tomwilkie
force-pushed
the
1169-frugal-frugal-frugal
branch
from
a53c652
to
669a0db
Compare
|
@paulbellamy PTAL |
paulbellamy
added a commit
that referenced
this pull request
Jul 30, 2015
Run integration tests in parallel when possible.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1169
The idea here is that most tests only need 1 host; each shard has 3. Therefore we should be able to run some tests in parallel on different hosts.
If this works, we could reduce the number of CircleCI shards and increase the number of VMs we give them, potentially making the tests shorter and use less resources.