This repository has been archived by the owner on Mar 31, 2023. It is now read-only.
Fix errors being thrown #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generate-machines-manifest.js:4
const input = std.param.String("instances", "instances.json");
^
TypeError: Cannot read property 'String' of undefined
at generate-machines-manifest.js:4:25
fbarl
reviewed
Oct 10, 2019
There was a problem hiding this comment.
Good catch @bobhenkel!
The changes you made didn't quite do the job for me, but applying the changes I suggested on top me it good again.
Please address them and then I'll approve 👍
Co-Authored-By: Filip Barl <filip.barl@gmail.com>
Co-Authored-By: Filip Barl <filip.barl@gmail.com>
bobhenkel
commented
Oct 10, 2019
fbarl
approved these changes
Oct 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
./generate-machines-manifest.shI'm seeing this error. This change appears to fix that issue.Fixes #98.