Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC #48: Split 'assert_precondition' into optional and non-optional variants #48

Merged
merged 5 commits into from Apr 3, 2020

Conversation

@stephenmcgruer
Copy link
Contributor

stephenmcgruer commented Mar 26, 2020

See web-platform-tests/wpt#21971 for background information

rfcs/assert_precondition_rename.md Outdated Show resolved Hide resolved
rfcs/assert_precondition_rename.md Outdated Show resolved Hide resolved
Copy link
Contributor

jgraham left a comment

Thanks for doing this!

@Hexcles
Copy link
Member

Hexcles commented Mar 27, 2020

Nit: I think we want to match the RFC number with the PR number, i.e. 48 for this one.

@stephenmcgruer
Copy link
Contributor Author

stephenmcgruer commented Mar 27, 2020

Nit: I think we want to match the RFC number with the PR number, i.e. 48 for this one.

Oh is that how that works? (I could not figure out how the RFC numbers were chosen other than incrementing.) We should document that. Which will require a PR. Which will cause RFCs to be skipped. Hrm.

@jgraham
Copy link
Contributor

jgraham commented Mar 27, 2020

Skipping numbers isn't a problem, we won't run out ;) The point is not to know the order of RFCs being submitted, or have a simple mechanism to count RFCs, but to have a simple relationship between the RFC document and the associated discussion.

@Hexcles
Copy link
Member

Hexcles commented Mar 27, 2020

PR numbers are not consecutive anyways because of issues.

@stephenmcgruer
Copy link
Contributor Author

stephenmcgruer commented Mar 27, 2020

Both very good points :). I'll send out a PR to document this, and update the text here.

@stephenmcgruer stephenmcgruer changed the title RFC #43: Split 'assert_precondition' into optional and non-optional variants RFC #48: Split 'assert_precondition' into optional and non-optional variants Mar 27, 2020
@stephenmcgruer
Copy link
Contributor Author

stephenmcgruer commented Mar 27, 2020

I'll send out a PR to document this

SHS0t0ATMRs

Sigh. I'll be over here, in the corner with people who don't read the README properly -_-

@stephenmcgruer
Copy link
Contributor Author

stephenmcgruer commented Apr 3, 2020

With two approvals and no dissenting comments in the last 7 days, I am merging this per the RFC process.

@stephenmcgruer stephenmcgruer merged commit 10b30d2 into master Apr 3, 2020
@stephenmcgruer stephenmcgruer deleted the smcgruer/assert_precondition branch Apr 3, 2020
stephenmcgruer added a commit to web-platform-tests/wpt that referenced this pull request Apr 3, 2020
See web-platform-tests/rfcs#48 and
#21971.

Note that this PR only implements the new methods; it does not port any
tests to use it or remove `assert_precondition` - that will be done in
follow-up PRs.
stephenmcgruer added a commit to web-platform-tests/wpt that referenced this pull request Apr 16, 2020
See web-platform-tests/rfcs#48 and
#21971.

Note that this PR only implements the new methods; it does not port any
tests to use it or remove `assert_precondition` - that will be done in
follow-up PRs.
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Apr 25, 2020
…mplements_optional, a=testonly

Automatic update from web-platform-tests
Implement assert_implements and assert_implements_optional (#22699)

See web-platform-tests/rfcs#48 and
web-platform-tests/wpt#21971.

Note that this PR only implements the new methods; it does not port any
tests to use it or remove `assert_precondition` - that will be done in
follow-up PRs.
--

wpt-commits: d97d993e1c3977da9fe88ca2c867cd4466582eee
wpt-pr: 22699
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request Apr 25, 2020
…mplements_optional, a=testonly

Automatic update from web-platform-tests
Implement assert_implements and assert_implements_optional (#22699)

See web-platform-tests/rfcs#48 and
web-platform-tests/wpt#21971.

Note that this PR only implements the new methods; it does not port any
tests to use it or remove `assert_precondition` - that will be done in
follow-up PRs.
--

wpt-commits: d97d993e1c3977da9fe88ca2c867cd4466582eee
wpt-pr: 22699
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Apr 25, 2020
…mplements_optional, a=testonly

Automatic update from web-platform-tests
Implement assert_implements and assert_implements_optional (#22699)

See web-platform-tests/rfcs#48 and
web-platform-tests/wpt#21971.

Note that this PR only implements the new methods; it does not port any
tests to use it or remove `assert_precondition` - that will be done in
follow-up PRs.
--

wpt-commits: d97d993e1c3977da9fe88ca2c867cd4466582eee
wpt-pr: 22699

UltraBlame original commit: fde21009ea5a2a3aeb672f7342b47e70984f2f2e
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Apr 25, 2020
…mplements_optional, a=testonly

Automatic update from web-platform-tests
Implement assert_implements and assert_implements_optional (#22699)

See web-platform-tests/rfcs#48 and
web-platform-tests/wpt#21971.

Note that this PR only implements the new methods; it does not port any
tests to use it or remove `assert_precondition` - that will be done in
follow-up PRs.
--

wpt-commits: d97d993e1c3977da9fe88ca2c867cd4466582eee
wpt-pr: 22699

UltraBlame original commit: fde21009ea5a2a3aeb672f7342b47e70984f2f2e
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Apr 25, 2020
…mplements_optional, a=testonly

Automatic update from web-platform-tests
Implement assert_implements and assert_implements_optional (#22699)

See web-platform-tests/rfcs#48 and
web-platform-tests/wpt#21971.

Note that this PR only implements the new methods; it does not port any
tests to use it or remove `assert_precondition` - that will be done in
follow-up PRs.
--

wpt-commits: d97d993e1c3977da9fe88ca2c867cd4466582eee
wpt-pr: 22699

UltraBlame original commit: fde21009ea5a2a3aeb672f7342b47e70984f2f2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.