RFC #48: Split 'assert_precondition' into optional and non-optional variants #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcorpan
reviewed
Mar 26, 2020
zcorpan
approved these changes
Mar 27, 2020
|
Nit: I think we want to match the RFC number with the PR number, i.e. 48 for this one. |
Oh is that how that works? (I could not figure out how the RFC numbers were chosen other than incrementing.) We should document that. Which will require a PR. Which will cause RFCs to be skipped. Hrm. |
|
Skipping numbers isn't a problem, we won't run out ;) The point is not to know the order of RFCs being submitted, or have a simple mechanism to count RFCs, but to have a simple relationship between the RFC document and the associated discussion. |
|
PR numbers are not consecutive anyways because of issues. |
|
Both very good points :). I'll send out a PR to document this, and update the text here. |
stephenmcgruer
changed the title
stephenmcgruer
commented
Mar 27, 2020
Sigh. I'll be over here, in the corner with people who don't read the README properly -_- |
|
With two approvals and no dissenting comments in the last 7 days, I am merging this per the RFC process. |
stephenmcgruer
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 3, 2020
See web-platform-tests/rfcs#48 and #21971. Note that this PR only implements the new methods; it does not port any tests to use it or remove `assert_precondition` - that will be done in follow-up PRs.
stephenmcgruer
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 16, 2020
See web-platform-tests/rfcs#48 and #21971. Note that this PR only implements the new methods; it does not port any tests to use it or remove `assert_precondition` - that will be done in follow-up PRs.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 25, 2020
…mplements_optional, a=testonly Automatic update from web-platform-tests Implement assert_implements and assert_implements_optional (#22699) See web-platform-tests/rfcs#48 and web-platform-tests/wpt#21971. Note that this PR only implements the new methods; it does not port any tests to use it or remove `assert_precondition` - that will be done in follow-up PRs. -- wpt-commits: d97d993e1c3977da9fe88ca2c867cd4466582eee wpt-pr: 22699
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Apr 25, 2020
…mplements_optional, a=testonly Automatic update from web-platform-tests Implement assert_implements and assert_implements_optional (#22699) See web-platform-tests/rfcs#48 and web-platform-tests/wpt#21971. Note that this PR only implements the new methods; it does not port any tests to use it or remove `assert_precondition` - that will be done in follow-up PRs. -- wpt-commits: d97d993e1c3977da9fe88ca2c867cd4466582eee wpt-pr: 22699
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Apr 25, 2020
…mplements_optional, a=testonly Automatic update from web-platform-tests Implement assert_implements and assert_implements_optional (#22699) See web-platform-tests/rfcs#48 and web-platform-tests/wpt#21971. Note that this PR only implements the new methods; it does not port any tests to use it or remove `assert_precondition` - that will be done in follow-up PRs. -- wpt-commits: d97d993e1c3977da9fe88ca2c867cd4466582eee wpt-pr: 22699 UltraBlame original commit: fde21009ea5a2a3aeb672f7342b47e70984f2f2e
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Apr 25, 2020
…mplements_optional, a=testonly Automatic update from web-platform-tests Implement assert_implements and assert_implements_optional (#22699) See web-platform-tests/rfcs#48 and web-platform-tests/wpt#21971. Note that this PR only implements the new methods; it does not port any tests to use it or remove `assert_precondition` - that will be done in follow-up PRs. -- wpt-commits: d97d993e1c3977da9fe88ca2c867cd4466582eee wpt-pr: 22699 UltraBlame original commit: fde21009ea5a2a3aeb672f7342b47e70984f2f2e
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Apr 25, 2020
…mplements_optional, a=testonly Automatic update from web-platform-tests Implement assert_implements and assert_implements_optional (#22699) See web-platform-tests/rfcs#48 and web-platform-tests/wpt#21971. Note that this PR only implements the new methods; it does not port any tests to use it or remove `assert_precondition` - that will be done in follow-up PRs. -- wpt-commits: d97d993e1c3977da9fe88ca2c867cd4466582eee wpt-pr: 22699 UltraBlame original commit: fde21009ea5a2a3aeb672f7342b47e70984f2f2e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See web-platform-tests/wpt#21971 for background information