Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC 72: Address space overrides. #72

Merged
merged 2 commits into from Mar 31, 2021

Conversation

letitz
Copy link
Contributor

@letitz letitz commented Nov 17, 2020

rfcs/address_space_overrides.md Outdated Show resolved Hide resolved
rfcs/address_space_overrides.md Outdated Show resolved Hide resolved
rfcs/address_space_overrides.md Show resolved Hide resolved
rfcs/address_space_overrides.md Outdated Show resolved Hide resolved
rfcs/address_space_overrides.md Outdated Show resolved Hide resolved
rfcs/address_space_overrides.md Show resolved Hide resolved
@stephenmcgruer
Copy link
Contributor

stephenmcgruer commented Dec 2, 2020

To keep this RFC up-to-date, at this point I believe WPT's stance* is that this should be done via browser flags rather than have the testrunner (or some setup done by the testrunner) have system privileges. Both Blink and Gecko infra have said that having privileges in this way is at least not commonly done (but not explicitly banned).

We would like to see the aforementioned issues against browsers opened and discussions occur there (please link to them in this discussion). If a reasonable number of browsers think the level of support is unacceptably high, we can revisit the system-privilege angle.

* Based on discussion between @jgraham and myself today, plus previous comments from @Hexcles

@letitz
Copy link
Contributor Author

letitz commented Dec 2, 2020

I will open issues against other browsers to seek their input. Thanks for the discussion so far!

@letitz
Copy link
Contributor Author

letitz commented Dec 8, 2020

Filed bug 1681316 against Firefox. Any help locating appropriate contacts within Mozilla to assign the bug to or cc on the bug is appreciated!

@letitz
Copy link
Contributor Author

letitz commented Dec 8, 2020

Filed bug 219642 against WebKit.

@letitz
Copy link
Contributor Author

letitz commented Dec 14, 2020

Thanks @jgraham for helping triage the Firefox bug. Does anyone on this thread have a contact at WebKit I could ask to get some traction on that bug?

@jgraham
Copy link
Contributor

jgraham commented Dec 14, 2020

@gsnedders perhaps

@letitz
Copy link
Contributor Author

letitz commented Dec 15, 2020

Thanks!

@letitz
Copy link
Contributor Author

letitz commented Mar 24, 2021

@stephenmcgruer I believe we have consent from Gecko (see @ddragana's comment above) and WebKit (see bug 219642).

OK with you to proceed?

@stephenmcgruer
Copy link
Contributor

OK with you to proceed?

Unfortunately I'm no longer working on WPT matters, so I don't want to say yes when the consequences are on others. Instead, passing this to foolip@ and jgraham@ to sign off. For the record, I think this should be good to go based on #72 (comment) and the subsequent work letitz has done.

@letitz
Copy link
Contributor Author

letitz commented Mar 26, 2021

Thanks for the redirect! @jgraham @foolip WDYT?

Copy link
Contributor

@jgraham jgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't followed the discussion leading up to this, but reading through the whole proposal it makes good sense to me. It seems like a good trade off among the alternatives considered.

@letitz
Copy link
Contributor Author

letitz commented Mar 29, 2021

Thanks for the reviews! I'm not familiar with this workflow: how does this PR get merged now?

@foolip
Copy link
Member

foolip commented Mar 29, 2021

As a newly returning member of the wpt core team there's a risk of embarrassing myself here, but per https://github.com/web-platform-tests/rfcs#the-rfc-process the latest "new information" would be your ping in #72 (comment) and we can consider this accepted if there's no further feedback by March 31.

@letitz
Copy link
Contributor Author

letitz commented Mar 29, 2021

Oh, I believed the previous discussion and your approvals were enough. It seems to me all stakeholders have had ample time to review this since November. Anyway, I won't haggle for 2 days after 5 months of waiting. Glad this is finally getting merged :)

@foolip
Copy link
Member

foolip commented Mar 29, 2021

@letitz I'm only unsure about the status of WebKit and wanted to be sure @gsnedders had the full 7 days after this became ready to go. https://bugs.webkit.org/show_bug.cgi?id=219642 doesn't load for me right now, but if the discussion has already happened there, then really we could go ahead.

Please feel free to prepare an implementation PR in the meantime.

@foolip
Copy link
Member

foolip commented Mar 31, 2021

Alright, two more days have passed, I'm merging this now.

@foolip foolip merged commit 106a437 into web-platform-tests:master Mar 31, 2021
@letitz letitz mentioned this pull request Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants