Skip to content

Commit

Permalink
Merge pull request #126 from w3c/include_fixup
Browse files Browse the repository at this point in the history
Fix combination of --include and --exclude; r=Ms2ger
  • Loading branch information
Ms2ger committed Jul 4, 2015
2 parents 5fcfd52 + 849b96e commit ee83833
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion wptrunner/manifestinclude.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def _include(self, test, path_components):
try:
skip_value = self.get("skip", {"test_type": test.item_type}).lower()
assert skip_value in ("true", "false")
return False if skip_value == "true" else True
return skip_value != "true"
except KeyError:
if node.parent is not None:
node = node.parent
Expand Down Expand Up @@ -107,6 +107,7 @@ def _add_rule(self, test_manifests, url, direction):
if component not in node.child_map:
new_node = IncludeManifest(DataNode(component))
node.append(new_node)
new_node.set("skip", node.get("skip", {}))

node = node.child_map[component]

Expand Down

0 comments on commit ee83833

Please sign in to comment.