Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove OWNERS who have not joined the web-platform-tests org #11293

Closed
foolip opened this issue Jun 1, 2018 · 7 comments · Fixed by #11888
Closed

Remove OWNERS who have not joined the web-platform-tests org #11293

foolip opened this issue Jun 1, 2018 · 7 comments · Fixed by #11888

Comments

@foolip
Copy link
Member

foolip commented Jun 1, 2018

As reported in #11201 (comment), everyone who is currently in any OWNERS file has been invited to the web-platform-tests org.

Currently, 74 people have not accepted the invite, and cannot be added to reviews by wpt-pr-bot.

Plan:

  1. Ping those 74 people on this issue and ask them to accept the invite
  2. After 2 weeks, ping the remaining people once more
  3. After 2 more weeks, remove the non-responders from OWNERS files.
@foolip
Copy link
Member Author

foolip commented Jun 1, 2018

@jgraham @tobie, before I go ahead with the first pinging, do you think this makes sense?

@foolip
Copy link
Member Author

foolip commented Jun 1, 2018

Doing a preview of the ping, only the first 50 are highlighted, so probably that's the limit on the number of people who can be mentioned in a single comment. Need to take that into account.

@jgraham
Copy link
Contributor

jgraham commented Jun 1, 2018

I think this is fine. I think in general I might be in favour of proactively removing inactive people from OWNERS files (e.g. in components with more than 10 PRs in the last 12 months, but where the owner has not done any reviews in that time), and this seems much more gentle than that.

@foolip
Copy link
Member Author

foolip commented Jun 1, 2018

Yep, I've considered something like that as well, and it's probably a fairly simple script to write. Maybe as the next round :) I'll go ahead and ping people on this issue now.

@foolip
Copy link
Member Author

foolip commented Jun 1, 2018

@alsemenov @aogilvie @atanassov @ayg @beidson @bethge @bradkemper @bsittler @cabanier @chaals @chenxix @chunywang @cptvitamin @danielweck @deepak-sa @dominiccooney @dumbmatter @edenchuang @engelke @eric-carlson @EvgenyAgafonchikov @fleizach @hakatashi @halindrome @hallvors @haoxli @hshiozawa @jdsmith3000 @jernoble @JianfengXu @jonathanKingston @Jxck, please see the issue description and visit https://github.com/orgs/web-platform-tests/invitation to accept the invitation, to be able to perform reviews in web-platform-tests. Thank you!

@foolip
Copy link
Member Author

foolip commented Jun 1, 2018

@kangxu @khaledhosny @klausw @kristijanburnik @kwkbtr @LeonScroggins @louaybassbouss @luser @minxhuang @nattokirai @nikosandronikos @odinho @omo @pozdnyakov @ronkorving @rsolomakhin @rubys @scottlow @sgrekhov @shishimaru @shs96c @SimonSapin @snsk @spanicker @svillar @tagawa @tantek @tcole3 @therealglazou @timvolodine @toji @tyoshino @uysalere @Volker-E @web-flow @xiaojunwu @xinliux @yunxiaoxie @zhaozihao @zhorvath @zolkis please see the issue description and visit https://github.com/orgs/web-platform-tests/invitation to accept the invitation, to be able to perform reviews in web-platform-tests. Thank you!

Everyone, I will lock this conversation as any further comments will spam a lot of people. Please ping me on any other issue or email me if there are concerns.

@web-platform-tests web-platform-tests locked and limited conversation to collaborators Jun 1, 2018
foolip added a commit that referenced this issue Jul 10, 2018
@foolip
Remove reviewers who have not joined the web-platform-tests org
3186c68 
Part of #11293.

Reminder also in #11568.

This does not fully resolve #11293, as a few non-responders where
there would be no remaining reviewers are left, and one known to be
out-of-office. These will be handled separately to finish this.
foolip added a commit that referenced this issue Jul 11, 2018
@foolip
Remove reviewers who have not joined the web-platform-tests org (#11888)
8fea122 
Part of #11293.

Reminder also in #11568.

This does not fully resolve #11293, as a few non-responders where
there would be no remaining reviewers are left, and one known to be
out-of-office. These will be handled separately to finish this.
@foolip
Copy link
Member Author

foolip commented Jul 11, 2018

Now done with a few exceptions. Final bits will be done in #11915 to avoid any more spam here. Thanks everyone!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove reviewers who have not joined the web-platform-tests org web-platform-tests/wpt
2 participants
@jgraham @foolip