easing-tests.js is out of date #15483

egirard · 2019-02-20T17:03:41Z

Looking at easing-tests.js in wpt, moz, and chromium, it seems that mozilla's is more recent than the others. It seems to have been updated in https://phabricator.services.mozilla.com/D9309 but those changes weren't upstreamed.

egirard · 2019-02-20T17:07:07Z

More specifically, there's a section starting at line 44 that includes:

 {
   desc: 'frames function',
   easing: 'frames(5)',
   easingFunction: framesTiming(5)
 },

BorisChiou · 2019-02-20T18:02:51Z

It seems the wpt bot didn't upstream the update of easing-tests.js. I can create a PR to update it if needed.

BorisChiou · 2019-02-20T18:09:41Z

@jgraham do you have any idea to re-trigger the wpt bot for the patch (https://phabricator.services.mozilla.com/D9309)?

birtles · 2019-02-21T00:43:07Z

Yeah, it looks like the sync bot picked up the changes in parts 2 and 8 of that patch series but not part 1:

There may have been a merge conflict apparently:

birtles · 2019-02-26T00:02:09Z

I followed up with @jgraham on this. He suspects a misresolved merge conflict and is going to look into it.

birtles · 2019-03-04T06:03:38Z

Fixed by a4bfa25.

As per web-platform-tests#15483, there was some sort of merge conflict that meant that part 1 of [Mozilla bug 1496619](https://bugzilla.mozilla.org/show_bug.cgi?id=1496619) did not get properly merged to web-platform-tests. PR web-platform-tests#15587 attempted to fix this but failed to delete two files in css-timing that were deleted in this changeset: https://hg.mozilla.org/mozilla-central/rev/b46aa2883e42

As per #15483, there was some sort of merge conflict that meant that part 1 of [Mozilla bug 1496619](https://bugzilla.mozilla.org/show_bug.cgi?id=1496619) did not get properly merged to web-platform-tests. PR #15587 attempted to fix this but failed to delete two files in css-timing that were deleted in this changeset: https://hg.mozilla.org/mozilla-central/rev/b46aa2883e42

gsnedders added the web-animations label Feb 21, 2019

birtles closed this as completed Mar 4, 2019

birtles mentioned this issue May 9, 2019

[css-easing] Drop old frames() timing function files #16742

Merged

Provide feedback