Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update idlharness to support constructor operations. #18722

Merged
merged 3 commits into from Aug 30, 2019

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Aug 28, 2019

@Ms2ger Ms2ger merged commit 41a1425 into master Aug 30, 2019
@Ms2ger Ms2ger deleted the idlharness-constructors branch August 30, 2019 13:02
@foolip
Copy link
Member

foolip commented Aug 31, 2019

Ouch, this regressed all tests depending on html.idl. You can see it in https://github.com/web-platform-tests/wpt/runs/207949624 right on this PR but I didn't check that when reviewing. You can also see all the broken tests live on wpt.fyi.

@web-platform-tests/wpt-core-team can someone quickly revert this? I don't have access to a computer with a command line this weekend, but can follow up with "stop this from happening again" types of bugs next week.

@lukebjerring a case for regression detection here :)

@foolip
Copy link
Member

foolip commented Aug 31, 2019

What the failure saya::

FAIL message: promise_test: Unhandled rejection with value: object "WebIDLParseError: Syntax error at line 1471, since `interface CustomElementRegistry`:
 define(DOMString name, CustomElementConstructor constructor, optional ElementDefinitionOptions
                        ^ Trailing comma in arguments list"

This looks like a webidl2.js regression to me.

@foolip
Copy link
Member

foolip commented Aug 31, 2019

For anyone who also didn't know, @jgraham pointed out that it is possible to revert from the GitHub UI. It shows up next to the "Ms2ger merged commit 41a1425 into master 21 hours ago" event.

@foolip
Copy link
Member

foolip commented Aug 31, 2019

I've filed w3c/webidl2.js#402.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants