Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webdriver tests should default to use the HTTPS protocol #28847

Open
whimboo opened this issue May 5, 2021 · 2 comments
Open

Webdriver tests should default to use the HTTPS protocol #28847

whimboo opened this issue May 5, 2021 · 2 comments

Comments

@whimboo
Copy link
Contributor

@whimboo whimboo commented May 5, 2021

As just noticed when trying to get a test with Cross-Origin-Opener-Policy added, the url fixture (which other fixtures like inline are based on) defaults to HTTP. That means we basically don't test anything for HTTPS right now, which is IMO a huge deficit.

Switching the default to HTTPS raises another question. How can we get a valid certificate added to the certificate store of each browser to not have to enable the acceptInsecureCerts capability? As @jgraham pointed out for Firefox it will be easy soon when his patch series from PR #28729.

But how does it look like for other browsers?

CC'ing @foolip, @burg, @JohnChen0, @bwalderman.

@foolip
Copy link
Member

@foolip foolip commented May 5, 2021

The problem of a trusted certificate is already solved since stuff like https://web-platform.test:8443 is used while running lots of testharness.is tests.

I have almost no experience with the WebDriver tests in WPT so I don't know if that setup is easy to reuse, or perhaps if it's already in use.

@whimboo
Copy link
Contributor Author

@whimboo whimboo commented May 5, 2021

That is great to know! I will have a look how easy it is to just use this port. As it looks like we shouldn't just use the first available port there:

port = server_config["ports"][protocol][0]

Do we have a list documented, which ports can be used for what purpose?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants