Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

./wpt run should find browsers on macOS #7125

Closed
gsnedders opened this issue Aug 31, 2017 · 4 comments
Closed

./wpt run should find browsers on macOS #7125

gsnedders opened this issue Aug 31, 2017 · 4 comments
Labels
infra priority:backlog wptrunner The automated test runner, commonly called through ./wpt run

Comments

@gsnedders
Copy link
Member

Currently, ./wpt run just looks in $PATH (or %PATH% on Windows); on macOS, browsers are almost always installed in /Applications or $HOME/Applications and we should search these too.

@foolip
Copy link
Member

foolip commented Oct 4, 2017

@youennf maybe you know how one would go about this?

@gsnedders
Copy link
Member Author

I think we just need a list of paths to check in /Applications and $HOME/Applications? I'm pretty sure there isn't a better way of doing this than hardcoding those paths and hardcoding a list of Application bundle names (like we already do for firefox, etc., on Linux), though that probably mean parsing the Info.plist to get the actual binary path which is a bit of a pain (Python 2's plistlib only supports the XML serialisation) though given we only need to do this on macOS we should be able to rely on the psutil tool to convert them to XML and then parse them.

@gsnedders gsnedders added the wptrunner The automated test runner, commonly called through ./wpt run label Nov 29, 2017
reuben added a commit to reuben/web-platform-tests that referenced this issue Mar 5, 2018
@qiuzhong
Copy link
Contributor

@gsnedders , PR #9806 was submitted to fix this and had been merged long ago. Can we close this issue now?

@gsnedders
Copy link
Member Author

Yeah, this works for most browsers now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra priority:backlog wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Development

No branches or pull requests

3 participants