XHR test bug fixes #103
Closed
XHR test bug fixes #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests (e.g. FormData tests) rely on the upload.php helper file
…work well on w3c-test.org
…did not in fact change document.body
…state is still 1 per spec, modifying test
…state is still 1 per spec, modifying test 2
…ges, aligning tests
…onger is 'fully active'
…onger 'fully active'
…tform-tests into XHRtestBugFixes
…l-multi-window-4 with XHR pull request 3's text
…t was not actually called, clarifies debugging test failures in some cases
… it to a new file
…tform-tests into XHRtestBugFixes
…lity is generally tested elsewhere now
…tform-tests into XHRtestBugFixes
…tform-tests into XHRtestBugFixes
…ge for (spoiler: only first)
…tform-tests into XHRtestBugFixes Conflicts: XMLHttpRequest/send-authentication-competing-names-passwords.htm
… 'false' as third argument...
…e user when HTTP auth fails
…WW-Authenticate challenge
jugglinmike
pushed a commit
to bocoup/wpt
that referenced
this pull request
Apr 11, 2017
…aces Support callback interfaces.
jgraham
added a commit
that referenced
this pull request
Apr 21, 2017
Fix servo support and improve running under debugger
jugglinmike
added a commit
to bocoup/wpt
that referenced
this pull request
Oct 22, 2019
Introduce a GitHub Action to monitor Pull Requests, storing relevant
information in the project's git repository (thus allowing the external
wptpr.live system to publish previews) and creating GitHub Deployments
(thus alerting contributors to the status of the preview). This Action
is triggered on a regular interval.
Introduce a second GitHub Action to monitor the state of the preview
system and communicate the relevant status to contributors via the Pull
Request UI. This Action is triggered for every GitHub Deployment created
in the previously-described Action.
For example, if three Pull Requests are updated, the first GitHub Action
will inspect them all. It will create GitHub Deployments only for the
"trusted" Pull Requests. A new GitHub Action will run for each of the
Deployments, polling the preview website until either the preview is
available or a timeout is reached. This Action will update the
deployment accordingly so that the author of each Pull Request author is
aware of the status of the preview site.
The following flow chart visually describes the same sequence:
sync
web-platform-testsgh-101 (trusted) ---> |
web-platform-testsgh-102 (untrusted) -> |
web-platform-testsgh-103 (trusted) ---> |
.----.
|sync|--------+---------------------.
'----' | |
.-------------. .-------------.
|deploy web-platform-testsgh-101| |deploy web-platform-testsgh-103|
'-------------' '-------------'
| |
poll for preview poll for preview
| |
web-platform-testsgh-101 <------ success ----- preview available poll for preview
|
web-platform-testsgh-103 <------- error --------------------------------- timeout
jugglinmike
added a commit
to bocoup/wpt
that referenced
this pull request
Nov 11, 2019
Introduce a GitHub Action to monitor Pull Requests, storing relevant
information in the project's git repository (thus allowing the external
wptpr.live system to publish previews) and creating GitHub Deployments
(thus alerting contributors to the status of the preview). This Action
is triggered on a regular interval.
Introduce a second GitHub Action to monitor the state of the preview
system and communicate the relevant status to contributors via the Pull
Request UI. This Action is triggered for every GitHub Deployment created
in the previously-described Action.
For example, if three Pull Requests are updated, the first GitHub Action
will inspect them all. It will create GitHub Deployments only for the
"trusted" Pull Requests. A new GitHub Action will run for each of the
Deployments, polling the preview website until either the preview is
available or a timeout is reached. This Action will update the
deployment accordingly so that the author of each Pull Request author is
aware of the status of the preview site.
The following flow chart visually describes the same sequence:
sync
web-platform-testsgh-101 (trusted) ---> |
web-platform-testsgh-102 (untrusted) -> |
web-platform-testsgh-103 (trusted) ---> |
.----.
|sync|--------+---------------------.
'----' | |
.-------------. .-------------.
|deploy web-platform-testsgh-101| |deploy web-platform-testsgh-103|
'-------------' '-------------'
| |
poll for preview poll for preview
| |
web-platform-testsgh-101 <------ success ----- preview available poll for preview
|
web-platform-testsgh-103 <------- error --------------------------------- timeout
stephenmcgruer
pushed a commit
that referenced
this pull request
Nov 20, 2019
Introduce a GitHub Action to monitor Pull Requests, storing relevant
information in the project's git repository (thus allowing the external
wptpr.live system to publish previews) and creating GitHub Deployments
(thus alerting contributors to the status of the preview). This Action
is triggered on a regular interval.
Introduce a second GitHub Action to monitor the state of the preview
system and communicate the relevant status to contributors via the Pull
Request UI. This Action is triggered for every GitHub Deployment created
in the previously-described Action.
For example, if three Pull Requests are updated, the first GitHub Action
will inspect them all. It will create GitHub Deployments only for the
"trusted" Pull Requests. A new GitHub Action will run for each of the
Deployments, polling the preview website until either the preview is
available or a timeout is reached. This Action will update the
deployment accordingly so that the author of each Pull Request author is
aware of the status of the preview site.
The following flow chart visually describes the same sequence:
sync
gh-101 (trusted) ---> |
gh-102 (untrusted) -> |
gh-103 (trusted) ---> |
.----.
|sync|--------+---------------------.
'----' | |
.-------------. .-------------.
|deploy gh-101| |deploy gh-103|
'-------------' '-------------'
| |
poll for preview poll for preview
| |
gh-101 <------ success ----- preview available poll for preview
|
gh-103 <------- error --------------------------------- timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've reviewed about half of the test suite, the spec has changed in various ways and bug fixes & alignment is required