Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stylesheet of link element when rel != stylesheet #10325

Merged
merged 1 commit into from Apr 5, 2018

Commits on Apr 5, 2018

  1. Remove stylesheet of link element when rel != stylesheet

    Stylesheets from link elements that previously have rel = "stylesheet"
    but then changed to something else should be removed/not considered
    anymore until the rel attribute is changed back to "stylesheet" again.
    
    Currently this works correctly for link elements in the document tree,
    but fails in link elements within a shadow tree because link elements
    in shadow tree with rel attribute != "stylesheet"  are skipped from
    processing. Because of that, the stylesheet in the link element was
    never cleared and no style recalc happened.
    JSBin from bug: http://jsbin.com/bojunajaju/edit?html,console,output
    
    Bug: 817355
    Change-Id: I57c71c79c0cc471d36eb988b8a81eef82c33548a
    Reviewed-on: https://chromium-review.googlesource.com/995116
    Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
    Reviewed-by: Hayato Ito <hayato@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#548357}
    rakina authored and chromium-wpt-export-bot committed Apr 5, 2018
    Copy the full SHA
    f7db3f4 View commit details
    Browse the repository at this point in the history