Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable attr-referrer script-tag tests #10976

Merged
merged 1 commit into from
May 15, 2018
Merged

Enable attr-referrer script-tag tests #10976

merged 1 commit into from
May 15, 2018

Conversation

domfarolino
Copy link
Member

@domfarolino domfarolino commented May 13, 2018 •
edited by wpt-pr-bot
Loading

As per the spec change whatwg/html#3678 we should probably enable the script-tag attr-referrer tests. Here I modified the spec JSON, removing script-tag from the disabled section and ran generate.py to generate the ncessary tests. I think that should be all that's necessary here?

/cc @zcorpan

@domfarolino domfarolino mentioned this pull request May 13, 2018
Merged
@zcorpan
Copy link
Member

zcorpan commented May 14, 2018

I restarted the failed Firefox job.

@zcorpan
Copy link
Member

zcorpan commented May 15, 2018

I'm not familiar with how these tests work, so I don't know if I'm a good person to review. @kristijanburnik can you take a look?

jdm
jdm approved these changes May 15, 2018
View reviewed changes
Copy link
Contributor

@jdm jdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm familiar with these tests. The generated tests here should be fine.

@jdm jdm merged commit f2417cc into web-platform-tests:master May 15, 2018
@domfarolino domfarolino deleted the attr-script-referrerpolicy branch May 16, 2018 07:11
@domfarolino
Copy link
Member Author

Just a note, I've filed #11023 to at some point figure out what might be necessary to support the referrer policy tests for imported scripts.

domenic pushed a commit to whatwg/html that referenced this pull request May 30, 2018
@domfarolino @domenic
Add referrerpolicy attribute support to <script>s
0d28f8f 
Closes w3c/webappsec-referrer-policy#96.

Tests: web-platform-tests/wpt#10976 (see also
web-platform-tests/wpt#11023).
alice pushed a commit to alice/html that referenced this pull request Jan 8, 2019
@domfarolino
Add referrerpolicy attribute support to <script>s
8b1d14d 
Closes w3c/webappsec-referrer-policy#96.

Tests: web-platform-tests/wpt#10976 (see also
web-platform-tests/wpt#11023).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm jdm approved these changes

@estark37 estark37 Awaiting requested review from estark37

@jeisinger jeisinger Awaiting requested review from jeisinger

@kristijanburnik kristijanburnik Awaiting requested review from kristijanburnik

Assignees
No one assigned
Labels
referrer-policy wg-webappsec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@domfarolino @zcorpan @jdm @wpt-pr-bot