HTML: Expect salvegable to be set to false for pagehide test #11294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also rename the manual test. Part of #11269.
zcorpan
force-pushed
the
zcorpan/unload-pagehide-timeout
branch
from
290722f
to
c5ec75c
Compare
foolip
reviewed
Jun 19, 2018
| @@ -4,9 +4,12 @@ | |||
| onpagehide = function() { | |||
| onpagehide = null; | |||
| setTimeout(function() { | |||
| parent.t.done() | |||
| parent.t.step_func(function() { assert_unreached('setTimeout survived navigatoin'); }) | |||
There was a problem hiding this comment.
parent.t.unreached_func('setTimeout survived navigatoin') would be more compact.
| @@ -2,4 +2,4 @@ | |||
| <title>Document salvagable state after setting pagehide handler</title> | |||
| <script>onpagehide = function() {setTimeout(function(){document.body.innerHTML = "PASS"}, 100)}</script> | |||
| <p>Click the link below then navigate back to this page. Shortly after returning you should see the text "PASS"</p> | |||
| <p><A href="manual-001-1.html">Click here</a> | |||
| <p><a href="pagehide-manual-1.html">Click here</a> | |||
There was a problem hiding this comment.
Clicking will now 404, is that part of the test, or accidental?
There was a problem hiding this comment.
It's not 404, that file was renamed.
There was a problem hiding this comment.
Oh, there's both pagehide-manual.html and pagehide-manual-1.html.
foolip
approved these changes
Jun 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also rename the manual test.
Part of #11269.
I will report an issue for whatwg/html about this test.