Prevent abort error from breaking test in FF (fixes #10792) #11614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for pushing this branch to web-platform-tests/wpt itself rather than a clone; I forgot to update the origin for my new checkout when the repo moved. :( But I figured it would be noisier to delete this and recreate it - happy to do so if needed, though. |
zcorpan
approved these changes
Jun 21, 2018
|
Thanks! No problem with creating branches here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test intentionally aborts a versionchange transaction, which results in an AbortError being fired at the IDBOpenDBRequest. In browsers that bubble event errors up to
window.error(i.e. Firefox) this will cause the harness to fail.Call preventDefault() on the error since it's expected.