[Gecko Bug 1470659] Move platformName test to separate file. #12260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specific tests for the platformName capability do not belong in the test for the response body structure. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1470659 gecko-commit: a3d141d56e531d882111ccf569c76427091ed088 gecko-integration-branch: mozilla-inbound gecko-reviewers: whimboo
For similar reasons as for platformName, tests for configuring the timeouts object do not belong in the same parent test as those for response body structure. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1470659 gecko-commit: 0ad9872c27e07e5f9dbbb62ec41e5be180e98f05 gecko-integration-branch: mozilla-inbound gecko-reviewers: automatedtester, whimboo
To be able to ignore tests for individual capabilities we need to parametrize these tests. geckodriver now supports setWindowRect, but fails the proxy capability test because it is for some reason not propagated back. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1470659 gecko-commit: b5d9ec944fe0e33bdea383a1f0114ada1dcabdc3 gecko-integration-branch: mozilla-inbound gecko-reviewers: whimboo
wpt-pr-bot
approved these changes
Aug 1, 2018
|
Travis timeouts for wdspec tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specific tests for the platformName capability do not belong in
the test for the response body structure.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1470659
gecko-commit: a3d141d56e531d882111ccf569c76427091ed088
gecko-integration-branch: mozilla-inbound
gecko-reviewers: whimboo