Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gecko Bug 1470659] Move platformName test to separate file. #12260

Merged
merged 3 commits into from
Aug 3, 2018
Merged

[Gecko Bug 1470659] Move platformName test to separate file. #12260

merged 3 commits into from
Aug 3, 2018

Commits on Aug 1, 2018

  1. Move platformName test to separate file. 

    Specific tests for the platformName capability do not belong in
the test for the response body structure.

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1470659
gecko-commit: a3d141d56e531d882111ccf569c76427091ed088
gecko-integration-branch: mozilla-inbound
gecko-reviewers: whimboo
    @andreastt @moz-wptsync-bot
    andreastt authored and moz-wptsync-bot committed Aug 1, 2018
    Configuration menu
    Copy the full SHA
    1d81783 View commit details
    Browse the repository at this point in the history

  2. Move timeouts test to separate file. 

    For similar reasons as for platformName, tests for configuring the
timeouts object do not belong in the same parent test as those for
response body structure.

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1470659
gecko-commit: 0ad9872c27e07e5f9dbbb62ec41e5be180e98f05
gecko-integration-branch: mozilla-inbound
gecko-reviewers: automatedtester, whimboo
    @andreastt @moz-wptsync-bot
    andreastt authored and moz-wptsync-bot committed Aug 1, 2018
    Configuration menu
    Copy the full SHA
    866c450 View commit details
    Browse the repository at this point in the history

  3. Parametrize capabilities tests. 

    To be able to ignore tests for individual capabilities we need to
parametrize these tests.  geckodriver now supports setWindowRect,
but fails the proxy capability test because it is for some reason
not propagated back.

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1470659
gecko-commit: b5d9ec944fe0e33bdea383a1f0114ada1dcabdc3
gecko-integration-branch: mozilla-inbound
gecko-reviewers: whimboo
    @andreastt @moz-wptsync-bot
    andreastt authored and moz-wptsync-bot committed Aug 1, 2018
    Configuration menu
    Copy the full SHA
    c2455b9 View commit details
    Browse the repository at this point in the history