Add WPT serialization tests for wasm modules #12488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 15, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1175490
branch
3 times, most recently
from
ac8cb23
to
3bc1a2f
Compare
|
@domenic Do you mind reviewing the wasm postmessage WPT tests I added at https://chromium-review.googlesource.com/1175490? They're essentially duplicated from the SAB tests you wrote. |
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1175490
branch
from
3bc1a2f
to
835d9e6
Compare
|
Will do, just trying to find some time! |
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1175490
branch
3 times, most recently
from
9cea7d7
to
cbd37c5
Compare
These WPT tests are based on similar tests in wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/ This also fixes some test failures for the SharedArrayBuffer tests. Bug: chromium:798572 Change-Id: I50b0edbebe4e97f5358513d248657d2831f48201 Reviewed-on: https://chromium-review.googlesource.com/1175490 Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#586480}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1175490
branch
from
cbd37c5
to
c941183
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These WPT tests are based on similar tests in
wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/
This also fixes some test failures for the SharedArrayBuffer tests.
Bug: chromium:798572
Change-Id: I50b0edbebe4e97f5358513d248657d2831f48201
Reviewed-on: https://chromium-review.googlesource.com/1175490
Reviewed-by: Marijn Kruisselbrink mek@chromium.org
Commit-Queue: Ben Smith binji@chromium.org
Cr-Commit-Position: refs/heads/master@{#586480}