[Gecko Bug 1485668] Fix reftest chain comparisons in marionette reftest implementation #12734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were previously using the original test url as the lhs for each comparison after the top level, rather than the previous rhs url as expected. Differential Revision: https://phabricator.services.mozilla.com/D4081 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1485668 gecko-commit: 0cd882a506cfa9c7489160d06437361430e0aa65 gecko-integration-branch: autoland gecko-reviewers: ato
wpt-pr-bot
approved these changes
Aug 29, 2018
|
This fails travis until the marionette changes make it into nightly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously using the original test url as the lhs for each
comparison after the top level, rather than the previous rhs url as
expected.
Differential Revision: https://phabricator.services.mozilla.com/D4081
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1485668
gecko-commit: 0cd882a506cfa9c7489160d06437361430e0aa65
gecko-integration-branch: autoland
gecko-reviewers: ato