Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Location sans browsing context #13435

Merged
merged 4 commits into from
Oct 31, 2018
Merged

Test Location sans browsing context #13435

merged 4 commits into from
Oct 31, 2018

Conversation

annevk
Copy link
Member

@annevk annevk commented Oct 9, 2018

Copy link
Member

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed for test structure and general reasonableness of what is being asserted, but please name .tentative. if this is merged before the spec change. (Doing that might make it easier to see cross-browser results.)

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests seem good but I have a readability improvement I'd really like to see if possible :)

return loc;
}

[
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty hard to read. It's more work for you but I'd suggest

[
  {
    prop: "href",
    expected: "about:blank",
    valuesToTry: ["https://example.com/", "/", "http://test:test/", "test test", "test:test", "chrome:fail"]
  },
  ...
}

domenic pushed a commit to whatwg/html that referenced this pull request Oct 31, 2018
Previously, the various pieces of spec text here assumed that a browsing
context always existed.

Tests: web-platform-tests/wpt#13435.

Fixes #3959.
@domenic domenic merged commit fce65eb into master Oct 31, 2018
@domenic domenic deleted the annevk/location-sans-bc branch October 31, 2018 19:20
mustaqahmed pushed a commit to mustaqahmed/html that referenced this pull request Feb 15, 2019
Previously, the various pieces of spec text here assumed that a browsing
context always existed.

Tests: web-platform-tests/wpt#13435.

Fixes whatwg#3959.
mustaqahmed pushed a commit to mustaqahmed/html that referenced this pull request Feb 15, 2019
Previously, the various pieces of spec text here assumed that a browsing
context always existed.

Tests: web-platform-tests/wpt#13435.

Fixes whatwg#3959.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants