Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch: change Response's statusText's default #14144

Merged
merged 1 commit into from Nov 20, 2018
Merged

Fetch: change Response's statusText's default #14144

merged 1 commit into from Nov 20, 2018

Conversation

annevk
Copy link
Member

@annevk annevk commented Nov 20, 2018

See whatwg/fetch#836 for context.

This also cleans up the code a bit.

@annevk
Fetch: change Response's statusText's default
7e82e62 
See whatwg/fetch#836 for context.

This also cleans up the code a bit.
@Ms2ger Ms2ger merged commit 99e9e99 into master Nov 20, 2018
@Ms2ger Ms2ger deleted the annevk/response-statustext-default branch November 20, 2018 16:43
@annevk annevk restored the annevk/response-statustext-default branch November 21, 2018 09:01
@annevk
Copy link
Member Author

annevk commented Nov 21, 2018

@jdm thanks for the review!

@Ms2ger I should have added a label, but maybe I can also ask to not merge my PRs as a general rule? I usually try to time them together with a change to the standard, which often awaits some kind of implementer feedback.

@annevk annevk deleted the annevk/response-statustext-default branch November 21, 2018 11:20
annevk added a commit to whatwg/fetch that referenced this pull request Nov 21, 2018
@annevk
Change Response's statusText's default
a3d423f 
The empty string is a better default as the field is optional in HTTP and rather meaningless. This way if you change the status and forget about statusText it won't give the mistaken impression things are OK.

Tests: web-platform-tests/wpt#14144.

Fixes #698.
@CrOrc CrOrc mentioned this pull request Mar 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm jdm approved these changes

@domfarolino domfarolino Awaiting requested review from domfarolino

@mnot mnot Awaiting requested review from mnot

@youennf youennf Awaiting requested review from youennf

@yutakahirano yutakahirano Awaiting requested review from yutakahirano

Assignees
No one assigned
Labels
fetch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@annevk @jdm @Ms2ger @wpt-pr-bot