Improve support and add infrastructure test for file upload #14402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
added
infra
wptrunner
andreastt
reviewed
Dec 6, 2018
jugglinmike
reviewed
Dec 6, 2018
jugglinmike
reviewed
Dec 6, 2018
Without this pref set, the marionette file upload codepath doesn't work.
|
Added some tests and updated. |
jgraham
force-pushed
the
file_upload
branch
4 times, most recently
from
9ce3cc5
to
6d5eaa0
Compare
jugglinmike
reviewed
Dec 7, 2018
jugglinmike
approved these changes
Dec 8, 2018
…ument This is helpful for constructing file:// URLs and for uploading files
jugglinmike
force-pushed
the
file_upload
branch
from
669d9f2
to
3879a96
Compare
|
Since you've squashed changes for earlier review feedback, I take it that you'd like this work landed as distinct commits. The most recent commit from me probably shouldn't be merged on its own, so I've taken the liberty to squash it. Hope that's okay! The original version of this branch is available here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.