Prevent webdriver client Session.close() exception #14715
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds handling for the case when the call to
self.send_session_command("DELETE", "window")
inSession.close()
intools/webdriver/webdriver/client.py
returns None.Otherwise without this change, the code ends up checking
len()
on the return value ofself.send_session_command("DELETE", "window")
, which can result in a "TypeError: object of type 'NoneType' has no len()" exception.Fixes #14714
If the code in this patch isn’t the right/best way (or the most idiomatic way in Python) to deal with the problem in #14714, then let’s use this PR branch to update the patch to fix it the right way.