Prevent webdriver client Session.close() exception #14715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds handling for the case when the call to
self.send_session_command("DELETE", "window") in Session.close() in
tools/webdriver/webdriver/client.py returns None.
Otherwise without this change, the code ends up checking len() on the
return value of self.send_session_command("DELETE", "window"), which can
result in a "TypeError: object of type 'NoneType' has no len()" exception.
Fixes #14714
andreastt
approved these changes
Jan 4, 2019
sideshowbarker
deleted the
sideshowbarker/webdriver-client-deleted-window-handles-fix
branch
|
Do we still have any test for the expected return value here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds handling for the case when the call to
self.send_session_command("DELETE", "window")inSession.close()intools/webdriver/webdriver/client.pyreturns None.Otherwise without this change, the code ends up checking
len()on the return value ofself.send_session_command("DELETE", "window"), which can result in a "TypeError: object of type 'NoneType' has no len()" exception.Fixes #14714
If the code in this patch isn’t the right/best way (or the most idiomatic way in Python) to deal with the problem in #14714, then let’s use this PR branch to update the patch to fix it the right way.