[Gecko Bug 1517322] Allow LSAN suppressions path to be set from wptrunner command line #15044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we assumed that the path for the lsan_suppressions.txt file was the same as the prefs path, which is correct in CI but wrong for local builds. This adds a --lsan-dir command line argument and sets it in mach to the correct value for local builds and uses the prefs directory as a default for backwards compatibility Differential Revision: https://phabricator.services.mozilla.com/D16024 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1517322 gecko-commit: f65f0c93a581bad32c5afb454f19596f701083f5 gecko-integration-branch: central gecko-reviewers: mccr8
wpt-pr-bot
added
infra
wptrunner
wpt-pr-bot
approved these changes
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we assumed that the path for the lsan_suppressions.txt file was the same as the prefs path,
which is correct in CI but wrong for local builds. This adds a --lsan-dir command line argument and sets
it in mach to the correct value for local builds and uses the prefs directory as a default for backwards
compatibility
Differential Revision: https://phabricator.services.mozilla.com/D16024
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1517322
gecko-commit: f65f0c93a581bad32c5afb454f19596f701083f5
gecko-integration-branch: central
gecko-reviewers: mccr8