Reland add tentative WPT tests for stale while revalidate handling. #15047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 24, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1434776
branch
3 times, most recently
from
61a88ca
to
16f1b89
Compare
Add test to ensure that handling the fetch doesn't trigger stale while revalidate loading. Add test to ensure that scripts and css loaded trigger a stale while revalidate cache hit. The PR for the spec changes is here: whatwg/fetch#853 This reland removes the resource timing and moves to css (instead of images) which were both unreliable. BUG=348877 Change-Id: Ibabd8d3fd0295bedc8259594fc926da6ab5cfc43 Reviewed-on: https://chromium-review.googlesource.com/c/1434776 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#626264}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1434776
branch
from
16f1b89
to
094c128
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test to ensure that handling the fetch doesn't trigger stale
while revalidate loading.
Add test to ensure that scripts and css loaded trigger a stale
while revalidate cache hit.
The PR for the spec changes is here:
whatwg/fetch#853
This reland removes the resource timing and moves to css (instead of
images) which were both unreliable.
BUG=348877
Change-Id: Ibabd8d3fd0295bedc8259594fc926da6ab5cfc43
Reviewed-on: https://chromium-review.googlesource.com/c/1434776
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626264}