Add Stale While Revalidate Handling #853

dtapuska · 2018-12-21T17:23:04Z

Define a new cache mode "async-stale-revalidated" to indicate that the
fetch stack should return a stale response if it can and aysnchronously
revalidate the response.

Fixes #852

Preview | Diff

annevk

I don't really like the name as fetches are already asynchronous. Perhaps we should simply use "stale-while-revalidate" as token name?

What about "must-revalidate" as @ziyunfei commented?

@mnot I'd like you to have a look too.

fetch.bs

annevk · 2019-01-18T10:38:26Z

cc @jakearchibald

fetch.bs

Add test to ensure that handling the fetch doesn't trigger stale while revalidate loading. Add test to ensure that scripts loaded trigger a stale while revalidate cache hit and resource timing entries are correct. The PR for the spec changes is here: whatwg/fetch#853 BUG=348877 Change-Id: Ib07b98d0d2595b6b99857161f830343bf7516518

Add test to ensure that handling the fetch doesn't trigger stale while revalidate loading. Add test to ensure that scripts loaded trigger a stale while revalidate cache hit and resource timing entries are correct. The PR for the spec changes is here: whatwg/fetch#853 BUG=348877 Change-Id: Ib07b98d0d2595b6b99857161f830343bf7516518 Reviewed-on: https://chromium-review.googlesource.com/c/1383297 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#625228}

This reverts commit 05cdb4d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 625228 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMDVjZGI0ZDFkOWNkYWEyZGYzZDkxY2Q5ZGMxNTBlZGE5MDNmZTM1Ygw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29/77482 Sample Failed Step: webkit_layout_tests Sample Flaky Test: virtual/outofblink-cors-ns/external/wpt/fetch/stale-while-revalidate/stale-script.tentative.html Original change's description: > Add tentative WPT tests for stale while revalidate handling. > > Add test to ensure that handling the fetch doesn't trigger stale > while revalidate loading. > > Add test to ensure that scripts loaded trigger a stale while revalidate > cache hit and resource timing entries are correct. > > The PR for the spec changes is here: > whatwg/fetch#853 > > BUG=348877 > > Change-Id: Ib07b98d0d2595b6b99857161f830343bf7516518 > Reviewed-on: https://chromium-review.googlesource.com/c/1383297 > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Ben Kelly <wanderview@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625228} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=348877 Change-Id: Ie11ef55a64fcf3e39781666b65a47bbd157f04a2 Reviewed-on: https://chromium-review.googlesource.com/c/1432937 Cr-Commit-Position: refs/heads/master@{#625497}

Add test to ensure that handling the fetch doesn't trigger stale while revalidate loading. Add test to ensure that scripts and css loaded trigger a stale while revalidate cache hit. The PR for the spec changes is here: whatwg/fetch#853 This reland removes the resource timing and moves to css (instead of images) which were both unreliable. BUG=348877 Change-Id: Ibabd8d3fd0295bedc8259594fc926da6ab5cfc43

Add test to ensure that handling the fetch doesn't trigger stale while revalidate loading. Add test to ensure that scripts and css loaded trigger a stale while revalidate cache hit. The PR for the spec changes is here: whatwg/fetch#853 This reland removes the resource timing and moves to css (instead of images) which were both unreliable. BUG=348877 Change-Id: Ibabd8d3fd0295bedc8259594fc926da6ab5cfc43 Reviewed-on: https://chromium-review.googlesource.com/c/1434776 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#626264}

dtapuska · 2019-01-28T14:22:20Z

This pull request now has tests that have been merged, I think the label can be removed.

annevk · 2019-01-28T14:30:29Z

@dtapuska so as far as I can tell the naming comment is still outstanding as well as the new ability to bypass service workers when it comes to network requests.

Also, is this parallel request fully defined? What if there's now a 401? Or a redirect (not followed per current rules)?

dtapuska · 2019-01-28T14:46:32Z

@annevk

We don't do anything different for 401s or redirects. It is exactly the same as another sub-resource; standard processing occurs. This is the benefit of having the revalidation associated with the context that initiated the resource request.

The text indicates "in parallel perform" is that the naming? I indicated "Done" on the comment above. Is that the naming you are referring to?

Did Kinuko's response not suffice? Top level requests are sent to the service worker if associated. Can you explain why you think the revalidation should go back to the service worker? Fetches created from the service worker have a "" destination.

annevk · 2019-01-28T14:51:09Z

@dtapuska if standard processing occurs, the current PR is wrong, right? It invokes an algorithm that doesn't handle redirects.

The naming comment is about "async" in the new enum value. Fetching is already asynchronous for all intents and purposes so this name is rather confusing.

As for the service worker, we don't have many fetches that can bypass it, so the problem would be that now there is a way and the service worker can do nothing about it. That breaks a design decision around service workers.

dtapuska · 2019-01-28T15:04:56Z

@annevk Sorry which enum value are you referring to? Only async I see in the pull request was in the title. I've since removed that.

So you are saying you want the algorithm to do in parallel the "HTTP redirect fetch" or a "HTTP fetch with service worker mode set to none" instead of going into the network or cache fetch directly. That seems to make sense.

fetch.bs

annevk · 2019-01-28T15:27:31Z

I'm not sure, it's still not clear to me what the processing model is, and I'd like someone other than me to judge it's suddenly okay to bypass service workers when making network requests. That seems like a new primitive and rather isolated at that.

fetch.bs

The PR has been merged into the fetch spec. whatwg/fetch#853 BUG=348877 Change-Id: I5e06ebee3b968e569453df51a441338fb93df72a

dtapuska · 2019-04-12T18:43:14Z

@dtapuska can you create a WPT PR that makes the tests no longer tentative? It'd also be nice to put the non-test resources into a resources/ subdirectory. I'm also a little concerned about https://bugzilla.mozilla.org/show_bug.cgi?id=1540216.

I'll take some time to create and push editorial fixup here for you to review.

PR for removing tentative and moving into resources is here:
web-platform-tests/wpt#16337

mayhemer · 2019-04-12T18:45:22Z

See also https://bugzilla.mozilla.org/show_bug.cgi?id=1543742

fetch.bs

annevk · 2019-05-03T13:01:53Z

Thanks @dtapuska for seeing this through. If you have ideas for how we could make this more streamlined for you in the future those would be welcome. Perhaps synchronous communication at some point could have helped to set mutual expectations better?

The PR has been merged into the fetch spec. whatwg/fetch#853 BUG=348877 Change-Id: I5e06ebee3b968e569453df51a441338fb93df72a

The PR has been merged into the fetch spec. whatwg/fetch#853 BUG=348877 Change-Id: I5e06ebee3b968e569453df51a441338fb93df72a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566154 Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#656466}

…-revalidate., a=testonly Automatic update from web-platform-tests Remove tentative suffix from stale-while-revalidate. The PR has been merged into the fetch spec. whatwg/fetch#853 BUG=348877 Change-Id: I5e06ebee3b968e569453df51a441338fb93df72a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566154 Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#656466} -- wpt-commits: 2905669d14b7a004c9a2f919a38a56f701c095c9 wpt-pr: 16337 --HG-- rename : testing/web-platform/tests/fetch/stale-while-revalidate/stale-css.py => testing/web-platform/tests/fetch/stale-while-revalidate/resources/stale-css.py rename : testing/web-platform/tests/fetch/stale-while-revalidate/stale-script.py => testing/web-platform/tests/fetch/stale-while-revalidate/resources/stale-script.py

…-revalidate., a=testonly Automatic update from web-platform-tests Remove tentative suffix from stale-while-revalidate. The PR has been merged into the fetch spec. whatwg/fetch#853 BUG=348877 Change-Id: I5e06ebee3b968e569453df51a441338fb93df72a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566154 Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#656466} -- wpt-commits: 2905669d14b7a004c9a2f919a38a56f701c095c9 wpt-pr: 16337

The PR has been merged into the fetch spec. whatwg/fetch#853 BUG=348877 Change-Id: I5e06ebee3b968e569453df51a441338fb93df72a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566154 Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#656466}

… while revalidate handling., a=testonly Automatic update from web-platform-tests Reland add tentative WPT tests for stale while revalidate handling. Add test to ensure that handling the fetch doesn't trigger stale while revalidate loading. Add test to ensure that scripts and css loaded trigger a stale while revalidate cache hit. The PR for the spec changes is here: whatwg/fetch#853 This reland removes the resource timing and moves to css (instead of images) which were both unreliable. BUG=348877 Change-Id: Ibabd8d3fd0295bedc8259594fc926da6ab5cfc43 Reviewed-on: https://chromium-review.googlesource.com/c/1434776 Commit-Queue: Dave Tapuska <dtapuskachromium.org> Reviewed-by: Ben Kelly <wanderviewchromium.org> Cr-Commit-Position: refs/heads/master{#626264} -- wpt-commits: f8a34bc8fa3a9451717c974108d677e319243ded wpt-pr: 15047 UltraBlame original commit: 53cc2cd5c20c298cc1d7b855d0053fe58856bc10

… while revalidate handling., a=testonly Automatic update from web-platform-tests Reland add tentative WPT tests for stale while revalidate handling. Add test to ensure that handling the fetch doesn't trigger stale while revalidate loading. Add test to ensure that scripts and css loaded trigger a stale while revalidate cache hit. The PR for the spec changes is here: whatwg/fetch#853 This reland removes the resource timing and moves to css (instead of images) which were both unreliable. BUG=348877 Change-Id: Ibabd8d3fd0295bedc8259594fc926da6ab5cfc43 Reviewed-on: https://chromium-review.googlesource.com/c/1434776 Commit-Queue: Dave Tapuska <dtapuskachromium.org> Reviewed-by: Ben Kelly <wanderviewchromium.org> Cr-Commit-Position: refs/heads/master{#626264} -- wpt-commits: f8a34bc8fa3a9451717c974108d677e319243ded wpt-pr: 15047 UltraBlame original commit: e65e05e0dfde39b8fa17ed514c9cdf72beaa0bb4

… while revalidate handling., a=testonly Automatic update from web-platform-tests Reland add tentative WPT tests for stale while revalidate handling. Add test to ensure that handling the fetch doesn't trigger stale while revalidate loading. Add test to ensure that scripts and css loaded trigger a stale while revalidate cache hit. The PR for the spec changes is here: whatwg/fetch#853 This reland removes the resource timing and moves to css (instead of images) which were both unreliable. BUG=348877 Change-Id: Ibabd8d3fd0295bedc8259594fc926da6ab5cfc43 Reviewed-on: https://chromium-review.googlesource.com/c/1434776 Commit-Queue: Dave Tapuska <dtapuskachromium.org> Reviewed-by: Ben Kelly <wanderviewchromium.org> Cr-Commit-Position: refs/heads/master{#626264} -- wpt-commits: f8a34bc8fa3a9451717c974108d677e319243ded wpt-pr: 15047 UltraBlame original commit: 53cc2cd5c20c298cc1d7b855d0053fe58856bc10

… while revalidate handling., a=testonly Automatic update from web-platform-tests Reland add tentative WPT tests for stale while revalidate handling. Add test to ensure that handling the fetch doesn't trigger stale while revalidate loading. Add test to ensure that scripts and css loaded trigger a stale while revalidate cache hit. The PR for the spec changes is here: whatwg/fetch#853 This reland removes the resource timing and moves to css (instead of images) which were both unreliable. BUG=348877 Change-Id: Ibabd8d3fd0295bedc8259594fc926da6ab5cfc43 Reviewed-on: https://chromium-review.googlesource.com/c/1434776 Commit-Queue: Dave Tapuska <dtapuskachromium.org> Reviewed-by: Ben Kelly <wanderviewchromium.org> Cr-Commit-Position: refs/heads/master{#626264} -- wpt-commits: f8a34bc8fa3a9451717c974108d677e319243ded wpt-pr: 15047 UltraBlame original commit: e65e05e0dfde39b8fa17ed514c9cdf72beaa0bb4

… while revalidate handling., a=testonly Automatic update from web-platform-tests Reland add tentative WPT tests for stale while revalidate handling. Add test to ensure that handling the fetch doesn't trigger stale while revalidate loading. Add test to ensure that scripts and css loaded trigger a stale while revalidate cache hit. The PR for the spec changes is here: whatwg/fetch#853 This reland removes the resource timing and moves to css (instead of images) which were both unreliable. BUG=348877 Change-Id: Ibabd8d3fd0295bedc8259594fc926da6ab5cfc43 Reviewed-on: https://chromium-review.googlesource.com/c/1434776 Commit-Queue: Dave Tapuska <dtapuskachromium.org> Reviewed-by: Ben Kelly <wanderviewchromium.org> Cr-Commit-Position: refs/heads/master{#626264} -- wpt-commits: f8a34bc8fa3a9451717c974108d677e319243ded wpt-pr: 15047 UltraBlame original commit: 53cc2cd5c20c298cc1d7b855d0053fe58856bc10

… while revalidate handling., a=testonly Automatic update from web-platform-tests Reland add tentative WPT tests for stale while revalidate handling. Add test to ensure that handling the fetch doesn't trigger stale while revalidate loading. Add test to ensure that scripts and css loaded trigger a stale while revalidate cache hit. The PR for the spec changes is here: whatwg/fetch#853 This reland removes the resource timing and moves to css (instead of images) which were both unreliable. BUG=348877 Change-Id: Ibabd8d3fd0295bedc8259594fc926da6ab5cfc43 Reviewed-on: https://chromium-review.googlesource.com/c/1434776 Commit-Queue: Dave Tapuska <dtapuskachromium.org> Reviewed-by: Ben Kelly <wanderviewchromium.org> Cr-Commit-Position: refs/heads/master{#626264} -- wpt-commits: f8a34bc8fa3a9451717c974108d677e319243ded wpt-pr: 15047 UltraBlame original commit: e65e05e0dfde39b8fa17ed514c9cdf72beaa0bb4

…-revalidate., a=testonly Automatic update from web-platform-tests Remove tentative suffix from stale-while-revalidate. The PR has been merged into the fetch spec. whatwg/fetch#853 BUG=348877 Change-Id: I5e06ebee3b968e569453df51a441338fb93df72a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566154 Reviewed-by: Mustaq Ahmed <mustaqchromium.org> Commit-Queue: Dave Tapuska <dtapuskachromium.org> Cr-Commit-Position: refs/heads/master{#656466} -- wpt-commits: 2905669d14b7a004c9a2f919a38a56f701c095c9 wpt-pr: 16337 UltraBlame original commit: 33c537619b8ff8ff6c4de79246c5ffc6fddcc766

uasan · 2019-12-01T23:17:22Z

Hi.
We really lack the ability to handle events, receive a new response, to a background asynchronous browser request.

Are there any plans to add such an event so that we can handler to it?
Prototype handler interface:

addEventListener('cache-stale-updated', event => myReRenderContent(event.response));

annevk · 2019-12-02T10:36:36Z

@uasan no plans, but if you want this to be considered properly please file a new issue, ideally after reading https://whatwg.org/faq#adding-new-features. Thanks!

dtapuska force-pushed the master branch from e5c5baa to b351056 Compare December 21, 2018 17:23

annevk reviewed Jan 2, 2019

View reviewed changes

fetch.bs Outdated Show resolved Hide resolved

fetch.bs Outdated Show resolved Hide resolved

dtapuska force-pushed the master branch from b351056 to 14280da Compare January 15, 2019 16:58

annevk added needs implementer interest Moving the issue forward requires implementers to express interest needs tests Moving the issue forward requires someone to write tests labels Jan 18, 2019

dtapuska force-pushed the master branch 2 times, most recently from da68bc4 to 788b7bc Compare January 21, 2019 21:27

kinu reviewed Jan 22, 2019

View reviewed changes

fetch.bs Outdated Show resolved Hide resolved

chromium-wpt-export-bot mentioned this pull request Jan 22, 2019

Add tentative WPT tests for stale while revalidate handling. web-platform-tests/wpt#14591

Closed

chromium-wpt-export-bot mentioned this pull request Jan 24, 2019

Reland add tentative WPT tests for stale while revalidate handling. web-platform-tests/wpt#15047

Merged

dtapuska changed the title ~~Add Async Stale While Revalidate Handling~~ Add Stale While Revalidate Handling Jan 28, 2019

annevk reviewed Jan 28, 2019

View reviewed changes

fetch.bs Outdated Show resolved Hide resolved

annevk reviewed Apr 5, 2019

View reviewed changes

fetch.bs Outdated Show resolved Hide resolved

fetch.bs Outdated Show resolved Hide resolved

fetch.bs Outdated Show resolved Hide resolved

chromium-wpt-export-bot mentioned this pull request Apr 12, 2019

Remove tentative suffix from stale-while-revalidate. web-platform-tests/wpt#16337

Merged

Link current age

1cef013

more tidying

e90e382

annevk reviewed Apr 15, 2019

View reviewed changes

fetch.bs Show resolved Hide resolved

dtapuska and others added 2 commits April 18, 2019 09:30

Add condition for non-null client

70532d3

nit

e17297b

annevk approved these changes May 3, 2019

View reviewed changes

annevk merged commit 49b92ee into whatwg:master May 3, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Stale While Revalidate Handling #853

Add Stale While Revalidate Handling #853

dtapuska commented Dec 21, 2018 •

edited by pr-preview bot

Loading

annevk left a comment

annevk commented Jan 18, 2019

dtapuska commented Jan 28, 2019

annevk commented Jan 28, 2019

dtapuska commented Jan 28, 2019

annevk commented Jan 28, 2019

dtapuska commented Jan 28, 2019

annevk commented Jan 28, 2019

dtapuska commented Apr 12, 2019

mayhemer commented Apr 12, 2019

annevk commented May 3, 2019

uasan commented Dec 1, 2019 •

edited

Loading

annevk commented Dec 2, 2019

Add Stale While Revalidate Handling #853

Add Stale While Revalidate Handling #853

Conversation

dtapuska commented Dec 21, 2018 • edited by pr-preview bot Loading

annevk left a comment

Choose a reason for hiding this comment

annevk commented Jan 18, 2019

dtapuska commented Jan 28, 2019

annevk commented Jan 28, 2019

dtapuska commented Jan 28, 2019

annevk commented Jan 28, 2019

dtapuska commented Jan 28, 2019

annevk commented Jan 28, 2019

dtapuska commented Apr 12, 2019

mayhemer commented Apr 12, 2019

annevk commented May 3, 2019

uasan commented Dec 1, 2019 • edited Loading

annevk commented Dec 2, 2019

dtapuska commented Dec 21, 2018 •

edited by pr-preview bot

Loading

uasan commented Dec 1, 2019 •

edited

Loading