Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1530048] part 2: Add test to verify that table, td, and th draw borders using 'currentColor'. #15748

Merged
merged 1 commit into from
Mar 15, 2019

Conversation

moz-wptsync-bot
Copy link
Collaborator

Differential Revision: https://phabricator.services.mozilla.com/D21249

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1530048
gecko-commit: 72127702116cd18973ab501edfcb04bdc4cbe68a
gecko-integration-branch: central
gecko-reviewers: dbaron

…'currentColor'.

Differential Revision: https://phabricator.services.mozilla.com/D21249

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1530048
gecko-commit: 72127702116cd18973ab501edfcb04bdc4cbe68a
gecko-integration-branch: central
gecko-reviewers: dbaron
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@dholbert
Copy link
Contributor

Failing check is wpt-firefox-nightly-stability, with some reftest screenshots that are blank, as we've seen elsewhere. Link to test run: https://taskcluster-artifacts.net/cmEA0yo2RZOZldUWpieJWA/0/public/logs/live_backing.log

This is a known issue (seen in #15661 (comment) and #15534 (comment) ) and it has nothing to do with this test, so it shouldn't block this test merging. @jgraham , would you mind force-merging?

@dholbert
Copy link
Contributor

dholbert commented Mar 13, 2019

For the record, if it helps for debugging the blank-screenshot issue down the road:
The failing wpt-firefox-nightly-stability testrun had two unexpected failures, both of which happened in the same testrun (one testrun with a failure in each test = 2 unexpected failures). In that testrun:

  • The screenshot of the first test (table-border-3q.html) was blank.
  • The screenshot of the second test (table-border-3s.html) was correct.
  • For both of those, the screenshot of the reference case was a bogus partially-white-partially-transparent image (with a transparent area on the right side) -- here's that screenshot:
    reference

@jgraham jgraham merged commit 13a6cae into master Mar 15, 2019
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1530048 branch March 18, 2019 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants