Adding OS Release and OS Build info to the run_info for Edge #15992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
added
infra
wptrunner
|
I'll leave this review to @gsnedders. |
gsnedders
requested changes
Mar 22, 2019
|
@gsnedders is there anything else I need to do? I've addressed your previous comments. I noticed some automated failures, but they don't seem related to my changes. |
|
@stanleyhon I think I got side-tracked into figuring out what was causing those failures, sorry! |
gsnedders
approved these changes
Mar 26, 2019
Ms2ger
reviewed
Apr 1, 2019
|
|
||
|
|
||
| def run_info_extras(**kwargs): | ||
| osReleaseCommand = "(Get-ItemProperty 'HKLM:\Software\Microsoft\Windows NT\CurrentVersion').ReleaseId" |
There was a problem hiding this comment.
/home/test/web-platform-tests/tools/wptrunner/wptrunner/browsers/edge.py:105: DeprecationWarning: invalid escape sequence \S
I guess this should have used double backslashes.
There was a problem hiding this comment.
Should probably be a raw string.
There was a problem hiding this comment.
Do I need to make a fresh PR to fix this up?
There was a problem hiding this comment.
I've put up a CR over here
marcoscaceres
pushed a commit
that referenced
this pull request
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding detailed OS Release and OS build info to the run_info for Edge runs.