Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gecko Bug 1539171] Make the list-item increment not visible from the computed style. #16485

Merged
merged 1 commit into from
Apr 25, 2019
Merged

[Gecko Bug 1539171] Make the list-item increment not visible from the computed style. #16485

merged 1 commit into from
Apr 25, 2019

Conversation

moz-wptsync-bot
Copy link
Collaborator

This is per https://drafts.csswg.org/css-lists/#declaring-a-list-item.

I intentionally kept

  • defined using attribute mapping, I think that's
    saner than special-casing it in layout.

    Differential Revision: https://phabricator.services.mozilla.com/D24935

    bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1539171
    gecko-commit: 4ec02d2be99e933a9599075f4e45c25687744111
    gecko-integration-branch: central
    gecko-reviewers: mats

    •

    @emilio @moz-wptsync-bot
    Make the list-item increment not visible from the computed style.
    054e360 
    This is per https://drafts.csswg.org/css-lists/#declaring-a-list-item.

I intentionally kept <li value> defined using attribute mapping, I think that's
saner than special-casing it in layout.

Differential Revision: https://phabricator.services.mozilla.com/D24935

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1539171
gecko-commit: 4ec02d2be99e933a9599075f4e45c25687744111
gecko-integration-branch: central
gecko-reviewers: mats
    wpt-pr-bot
    wpt-pr-bot approved these changes Apr 25, 2019
    View reviewed changes
    Copy link
    Collaborator

    @wpt-pr-bot wpt-pr-bot left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Already reviewed downstream.

    @jgraham jgraham merged commit 11f61ad into master Apr 25, 2019
    @moz-wptsync-bot moz-wptsync-bot deleted the gecko/1539171 branch April 25, 2019 16:48
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @wpt-pr-bot wpt-pr-bot wpt-pr-bot approved these changes

    Assignees
    No one assigned
    Labels
    css-lists mozilla:gecko-sync
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    4 participants
    @moz-wptsync-bot @wpt-pr-bot @jgraham @emilio