Test that changing <iframe srcdoc> processes attributes #17437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
annevk,
domenic,
foolip,
jdm,
jgraham,
zcorpan and
zqzhang
annevk
approved these changes
Jun 28, 2019
html/semantics/embedded-content/the-iframe-element/srcdoc_process_attributes.html
Outdated
Show resolved
Hide resolved
html/semantics/embedded-content/the-iframe-element/srcdoc_process_attributes.html
Outdated
Show resolved
Hide resolved
html/semantics/embedded-content/the-iframe-element/srcdoc_process_attributes.html
Outdated
Show resolved
Hide resolved
html/semantics/embedded-content/the-iframe-element/srcdoc_process_attributes.html
Outdated
Show resolved
Hide resolved
html/semantics/embedded-content/the-iframe-element/srcdoc_process_attributes.html
Outdated
Show resolved
Hide resolved
|
@annevk @shvaikalesh This test asserts that a srcdoc iframe's load event is fired before returning from the srcdoc attribute modification. Where in the specification is that requirement documented? |
3 tasks
|
I missed that, that's indeed wrong. @shvaikalesh would you be willing to change the relevant |
annevk
pushed a commit
that referenced
this pull request
Nov 5, 2019
* "Changing" => "Setting", per #17437 (comment). * "load" event should fire after "srcdoc" attribute modification, per #17437 (comment).
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 29, 2019
…c> attributes processing test, a=testonly Automatic update from web-platform-tests Fix incorrect assertion in <iframe srcdoc> attributes processing test * "Changing" => "Setting", per web-platform-tests/wpt#17437 (comment). * "load" event should fire after "srcdoc" attribute modification, per web-platform-tests/wpt#17437 (comment). -- wpt-commits: 08f5e4f43dce6826d9a045eff8d85327c95ca2f3 wpt-pr: 20084
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Nov 29, 2019
…c> attributes processing test, a=testonly Automatic update from web-platform-tests Fix incorrect assertion in <iframe srcdoc> attributes processing test * "Changing" => "Setting", per web-platform-tests/wpt#17437 (comment). * "load" event should fire after "srcdoc" attribute modification, per web-platform-tests/wpt#17437 (comment). -- wpt-commits: 08f5e4f43dce6826d9a045eff8d85327c95ca2f3 wpt-pr: 20084
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Nov 30, 2019
…c> attributes processing test, a=testonly Automatic update from web-platform-tests Fix incorrect assertion in <iframe srcdoc> attributes processing test * "Changing" => "Setting", per web-platform-tests/wpt#17437 (comment). * "load" event should fire after "srcdoc" attribute modification, per web-platform-tests/wpt#17437 (comment). -- wpt-commits: 08f5e4f43dce6826d9a045eff8d85327c95ca2f3 wpt-pr: 20084 UltraBlame original commit: 1b5b5472a966c53402fc44b09c6e47f084691eab
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Nov 30, 2019
…c> attributes processing test, a=testonly Automatic update from web-platform-tests Fix incorrect assertion in <iframe srcdoc> attributes processing test * "Changing" => "Setting", per web-platform-tests/wpt#17437 (comment). * "load" event should fire after "srcdoc" attribute modification, per web-platform-tests/wpt#17437 (comment). -- wpt-commits: 08f5e4f43dce6826d9a045eff8d85327c95ca2f3 wpt-pr: 20084 UltraBlame original commit: 1b5b5472a966c53402fc44b09c6e47f084691eab
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Nov 30, 2019
…c> attributes processing test, a=testonly Automatic update from web-platform-tests Fix incorrect assertion in <iframe srcdoc> attributes processing test * "Changing" => "Setting", per web-platform-tests/wpt#17437 (comment). * "load" event should fire after "srcdoc" attribute modification, per web-platform-tests/wpt#17437 (comment). -- wpt-commits: 08f5e4f43dce6826d9a045eff8d85327c95ca2f3 wpt-pr: 20084 UltraBlame original commit: 1b5b5472a966c53402fc44b09c6e47f084691eab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blink bug: srcdoc removal does not process iframe attributes.
WebKit bug:
<iframe>attributes should be processed on "srcdoc" attribute removal.