Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML: WPT for tabIndex #17657

Merged
merged 6 commits into from Aug 15, 2019
Merged

HTML: WPT for tabIndex #17657

merged 6 commits into from Aug 15, 2019

Conversation

@rakina
Copy link
Contributor

rakina commented Jul 5, 2019

See whatwg/html#4754 for the spec change.

This is consistent with behaviors in Chrome, Safari, Firefox - see table in whatwg/html#4464 (comment) Chrome is failing for the case with shadow host with delegatesFocus=true)

@annevk
annevk approved these changes Jul 8, 2019
Copy link
Member

annevk left a comment

Thanks! Only have some optional nits.

@domenic
domenic approved these changes Jul 8, 2019
Copy link
Member

domenic left a comment

LGTM with @annevk's nits. I'm glad you tested the cases like disabled/hidden and has a href/doesn't have a href.

It's impressive that all browsers agree here.

rakina added 2 commits Jul 9, 2019
@annevk annevk assigned domenic and unassigned zcorpan Jul 9, 2019
domenic added a commit to whatwg/html that referenced this pull request Jul 9, 2019
This updates the tabIndex getter's default value to be 0 for a specific
list of element types, instead of the spec's previous "elements that are
focusable". This matches reality better; apart from minor edge cases
all three browser engines match this spec in observable behavior.

Closes #1786. Closes #4464. See the focus meta-bug in #4607 for related
discussions, including on adding an API that actually reflects whether
an element is focusable (like the tabIndex getter was kind-of supposed
to do).

Tests: web-platform-tests/wpt#17657
@domenic domenic mentioned this pull request Jul 9, 2019
3 of 3 tasks complete
@rniwa
Copy link
Contributor

rniwa commented Aug 15, 2019

Let's merge this test.

@rniwa rniwa merged commit a669334 into web-platform-tests:master Aug 15, 2019
10 checks passed
10 checks passed
wpt.fyi - chrome[experimental] Chrome results
Details
wpt.fyi - firefox[experimental] Firefox results
Details
wpt.fyi - safari[experimental] Safari results
Details
Azure Pipelines Build #20190709.243 succeeded
Details
Azure Pipelines (./wpt test-jobs) ./wpt test-jobs succeeded
Details
Azure Pipelines (affected tests without changes: Safari Technology Preview) affected tests without changes: Safari Technology Preview succeeded
Details
Azure Pipelines (affected tests: Safari Technology Preview) affected tests: Safari Technology Preview succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests) wpt.fyi hook: safari-preview-affected-tests succeeded
Details
Azure Pipelines (wpt.fyi hook: safari-preview-affected-tests-without-changes) wpt.fyi hook: safari-preview-affected-tests-without-changes succeeded
Details
Taskcluster (pull_request) TaskGroup: success
Details
natechapin added a commit to natechapin/wpt that referenced this pull request Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.