Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Safari Technology Preview 91 on macOS Mojave #18925

Closed
wants to merge 11 commits into from

Conversation

@foolip
Copy link
Contributor

foolip commented Sep 9, 2019

No description provided.

@foolip foolip force-pushed the foolip/stp-91 branch from 4d91049 to 2ce6611 Sep 9, 2019
@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Sep 9, 2019

Nope, still the same problem with "Could not create a session: You must enable the 'Allow Remote Automation' option in Safari's Develop menu to control Safari via WebDriver." Over to you, @gsnedders.

@wpt-pr-bot wpt-pr-bot requested review from gsnedders, jgraham and jugglinmike Sep 9, 2019
@foolip foolip added this to To do in Reliable Safari results via automation Sep 9, 2019
foolip added 5 commits Sep 10, 2019
This reverts commit 454e899.
@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Sep 10, 2019

@mustjab I feel I'm really close to finding a solution here, but I don't know the password of the vsts user on the macOS images, nor can I figure out how to reset it. Is it a dummy password that is documented somewhere?

foolip added 2 commits Sep 10, 2019
@mustjab

This comment has been minimized.

Copy link
Contributor

mustjab commented Sep 10, 2019

@foolip Asked pipeline team and they say that you should have password-less sudo on the Mac agents.

@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Sep 10, 2019

Yes, sudo is password-less and that works, but it looks like safaridriver --enable now has to run as the same user that will launch safaridriver and it looks like it's safaridriver itself that asks for a password. At least I can't find a workaround :(

@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Sep 11, 2019

#18610 was the previous attempt to upgrade to STP 90.

foolip added 2 commits Sep 11, 2019
@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Sep 11, 2019

@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Sep 11, 2019

https://staging.wpt.fyi/results/?diff&filter=ADC&run_id=247230003&run_id=253230003 shows the difference in results between master (STP 82) and this (STP 91). There are a bunch of improvements, but the regression due to https://bugs.webkit.org/show_bug.cgi?id=174030 seems to outweigh this.

Let's wait for STP 92.

@foolip foolip closed this Sep 11, 2019
Reliable Safari results automation moved this from To do to Done Sep 11, 2019
@foolip foolip deleted the foolip/stp-91 branch Sep 11, 2019
@foolip

This comment has been minimized.

Copy link
Contributor Author

foolip commented Sep 18, 2019

STP 92 is here: #19142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants
You can’t perform that action at this time.